ThreeSixtyGiving / registry-classic

Registry for 360Giving files that were published
Other
0 stars 0 forks source link

Features not included and determination of whether in month/year badge is included #92

Closed michaelwood closed 1 year ago

michaelwood commented 2 years ago

"If a publishers data has the 1 year and/or 3 month badges in This data includes these features section, they are also repeated in the This data does not include these features section too.

https://qualitydashboard.threesixtygiving.org/publisher/360G-ATJF https://qualitydashboard.threesixtygiving.org/publisher/360G-tnlcomfund

(via @KDuerden )

fixing hint: This is likely because the date calculation isn't a simple true/false evaluation so logical condition is evaluating the presence of the date delta output rather than it being in a range.

KDuerden commented 2 years ago

Is it possible to rationalise these badges, so only one is displayed in the includes / excludes sections?

codemacabre commented 1 year ago

@michaelwood Is this still an issue? I can't seem to reproduce it.

mariongalley commented 1 year ago

Agreed this is not worth the effort