ThreeSixtyGiving / registry-classic

Registry for 360Giving files that were published
Other
0 stars 0 forks source link

Add 360's favicon to dashboard #94

Closed michaelwood closed 1 year ago

BibianaC commented 2 years ago

@michaelwood The favicon is already in the code https://github.com/ThreeSixtyGiving/registry/blob/dashboard/registry-vue/public/index.html#L26 and above.

<link rel="shortcut icon" href="@/assets/images/favicon/favicon.ico" type="image/x-icon" />

The path is right https://github.com/ThreeSixtyGiving/registry/tree/dashboard/registry-vue/src/assets/images/favicon

michaelwood commented 2 years ago

It isn't correct somewhere though:

$ curl -vvv https://qualitydashboard.threesixtygiving.org/@/assets/images/favicon/favicon.ico
*   Trying 2a00:1098:84:1fb::3:1:443...
* TCP_NODELAY set
* Connected to qualitydashboard.threesixtygiving.org (2a00:1098:84:1fb::3:1) port 443 (#0)
* ALPN, offering h2
* ALPN, offering http/1.1
* successfully set certificate verify locations:
*   CAfile: /etc/ssl/certs/ca-certificates.crt
  CApath: /etc/ssl/certs
* TLSv1.3 (OUT), TLS handshake, Client hello (1):
* TLSv1.3 (IN), TLS handshake, Server hello (2):
* TLSv1.3 (IN), TLS handshake, Encrypted Extensions (8):
* TLSv1.3 (IN), TLS handshake, Certificate (11):
* TLSv1.3 (IN), TLS handshake, CERT verify (15):
* TLSv1.3 (IN), TLS handshake, Finished (20):
* TLSv1.3 (OUT), TLS change cipher, Change cipher spec (1):
* TLSv1.3 (OUT), TLS handshake, Finished (20):
* SSL connection using TLSv1.3 / TLS_AES_256_GCM_SHA384
* ALPN, server accepted to use h2
* Server certificate:
*  subject: CN=qualitydashboard.360dokku1.vs.mythic-beasts.com
*  start date: Jun  1 11:10:01 2022 GMT
*  expire date: Aug 30 11:10:00 2022 GMT
*  subjectAltName: host "qualitydashboard.threesixtygiving.org" matched cert's "qualitydashboard.threesixtygiving.org"
*  issuer: C=US; O=Let's Encrypt; CN=R3
*  SSL certificate verify ok.
* Using HTTP2, server supports multi-use
* Connection state changed (HTTP/2 confirmed)
* Copying HTTP/2 data in stream buffer to connection buffer after upgrade: len=0
* Using Stream ID: 1 (easy handle 0x55823219d2f0)
> GET /@/assets/images/favicon/favicon.ico HTTP/2
> Host: qualitydashboard.threesixtygiving.org
> user-agent: curl/7.68.0
> accept: */*
> 
* TLSv1.3 (IN), TLS handshake, Newsession Ticket (4):
* TLSv1.3 (IN), TLS handshake, Newsession Ticket (4):
* old SSL session ID is stale, removing
* Connection state changed (MAX_CONCURRENT_STREAMS == 128)!
< HTTP/2 200 
< server: nginx
< date: Mon, 20 Jun 2022 09:49:22 GMT
< content-type: text/html; charset=utf-8
< content-length: 5885
< vary: Accept-Encoding
< strict-transport-security: max-age=15724800; includeSubdomains
< 
<!DOCTYPE html><html lang=""><head><meta charset="utf-8"><meta http-equiv="X-UA-Compatible" content="IE=edge,chrome=1"><title>Quality Dashboard | 360Giving</title><meta property="og:title" content="Quality Dashboard | 360Giving"><meta name="viewport" content="width=device-width,initial-scale=1"><link rel="apple-touch-icon" sizes="57x57" href="@/assets/images/favicon/apple-icon-57x57.png"><link rel="apple-touch-icon" sizes="60x60" href="@/assets/images/favicon/apple-icon-60x60.png"><link rel="apple-touch-icon" sizes="72x72" href="@/assets/images/favicon/apple-icon-72x72.png"><link rel="apple-touch-icon" sizes="76x76" href="@/assets/images/favicon/apple-icon-76x76.png"><link rel="apple-touch-icon" sizes="114x114" href="@/assets/images/favicon/apple-icon-114x114.png"><link rel="apple-touch-icon" sizes="120x120" href="@/assets/images/favicon/apple-icon-120x120.png"><link rel="apple-touch-icon" sizes="144x144" href="@/assets/images/favicon/apple-icon-144x144.png"><link rel="apple-touch-icon" sizes="152x152" href="@/assets/images/favicon/apple-icon-152x152.png"><link rel="apple-touch-icon" sizes="180x180" href="@/assets/images/favicon/apple-icon-180x180.png"><link rel="icon" type="image/png" sizes="192x192" href="@/assets/images/favicon/android-icon-192x192.png"><link rel="icon" type="image/png" sizes="32x32" href="@/assets/images/favicon/favicon-32x32.png"><link rel="icon" type="image/png" sizes="96x96" href="@/assets/images/favicon/favicon-96x96.png"><link rel="icon" type="image/png" sizes="16x16" href="@/assets/images/favicon/favicon-16x16.png"><link rel="manifest" href="@/assets/images/favicon/manifest.json"><meta name="msapplication-TileColor" content="#ffffff"><meta name="msapplication-TileImage" content="@/assets/images/favicon/ms-icon-144x144.png"><meta name="theme-color" content="#ffffff"><link rel="shortcut icon" href="@/assets/images/favicon/favicon.ico" type="image/x-icon"><link rel="stylesheet" href="https://fonts.googleapis.com/css?family=Roboto:300,300i,400,400i,700,700i&display=swap" type="text/css"><link rel="stylesheet" href="https://fonts.googleapis.com/icon?family=Material+Icons" type="text/css"><link rel="stylesheet" href="@/assets/css/main.css" type="text/css"><noscript><style>.javascript-enabled {
          display: none !important;
        }</style></noscript><link href="/dashboard/../../static/vue-build/css/app.eaee1d67.css" rel="preload" as="style"><link href="/dashboard/../../static/vue-build/js/app.7cbb93dd.js" rel="preload" as="script"><link href="/dashboard/../../static/vue-build/js/chunk-vendors.6a04f4b5.js" rel="preload" as="script"><link href="/dashboard/../../static/vue-build/css/app.eaee1d67.css" rel="stylesheet"></head><body><noscript><strong>We're sorry but registry-vue doesn't work properly without JavaScript enabled. Please enable it to continue.</strong></noscript><div id="app"></div><div role="dialog" aria-labelledby="cookie-dialog-title" aria-describedby="cookie-dialog-desc"><div class="base-card base-card--new cookie-consent"><div class="base-card__content"><h2 class="base-card__title" id="cookie-dialog-title">Allow analytics cookies?<br><a class="base-card__text" href="https://www.threesixtygiving.org/privacy/">More Information &amp; Privacy Policy</a></h2><p class="base-card__text"><a href="#" onclick="_paq.push(['rememberCookieConsentGiven']); hideCookieConsentDialog(true);" class="button">Yes</a> <a href="#" onclick="noCookieConsent(); hideCookieConsentDialog(true);" class="button">No</a> <a href="#" onclick="_paq.push(['optUserOut']); hideCookieConsentDialog(true);" class="button">Disable Analytics</a></p><p id="cookie-dialog-desc" style="font-style: italic;">360Giving uses privacy-respecting analytics. If you don't accept cookies, we will track only basic information about your visit. Click "Disable Analytics" if you don't want us to track at all.</p></div></div></div><script>var _paq = window._paq = window._paq || [];
      var siteID = 26;
      /* tracker methods like "setCustomDimension" should be called before "trackPageView" */
      _paq.push(['requireCookieConsent']); // Don't use cookies unless we have consent
      _paq.push(['setCookieDomain', '*.threesixtygiving.org']);
      _paq.push(['setDomains', '*.threesixtygiving.org']);
      _paq.push(['setDownloadExtensions', "json|csv|xlsx"]);
      _paq.push(['trackPageView']);
      _paq.push(['enableLinkTracking']);
      (function () {
        var u = "https://analytics.threesixtygiving.org/";
        _paq.push(['setTrackerUrl', u + 'matomo.php']);
        if (!siteID) throw new Error("siteID not set");
        _paq.push(['setSiteId', siteID]);
        var d = document, g = d.createElement('script'), s = d.getElementsByTagName('script')[0];
        g.type = 'text/javascript'; g.async = true; g.src = u + 'matomo.js'; s.parentNode.insertBefore(g, s);
      })();</script><script>function hideCookieConsentDialog(hide) {
        if (hide) {
          document.getElementsByClassName("cookie-consent")[0].style.setProperty("display", "none", "important");
        } else {
          document.getElementsByClassName("cookie-consent")[0].style.setProperty("display", "block", "important");
        }
      }

      function noCookieConsent() {
        document.cookie = "noEnhancedAnalytics=1; domain=threesixtygiving.org";
      }

      document.addEventListener('DOMContentLoaded', function () {
        if (document.cookie.indexOf("mtm_cookie_consent") > -1 ||
          document.cookie.indexOf("mtm_consent_removed") > -1 ||
          document.cookie.indexOf("noEnhancedAnalytics") > -1) {
          hideCookieConsentDialog(true);
        } else {
          hideCookieConsentDialog(false);
        }
* Connection #0 to host qualitydashboard.threesixtygiving.org left intact
      });</script><script src="/dashboard/../../static/vue-build/js/chunk-vendors.6a04f4b5.js"></script><script src="/dashboard/../../static/vue-build/js/app.7c

The home page is being returned instead of the icon.

mariongalley commented 2 years ago

image

Lathrisk commented 2 years ago

This has now been deployed.