search

ThreeSixtyGiving / standard

The 360Giving data standard for UK philanthropic giving
http://www.threesixtygiving.org
Other
10 stars 15 forks source link

[#186] duration (months) string to float #238

Closed BobHarper1 closed 6 years ago

BobHarper1 commented 6 years ago

A bug fix as discussed on the Forum https://forum.threesixtygiving.org/t/planned-dates-duration-months-field/188

BobHarper1 commented 6 years ago

Cheers, we'll put the merge on the long finger.

BobHarper1 commented 6 years ago

For clarity, I've now changed this so that it will be an integer (which makes more sense when we're talking about months) and removes any ambiguity (cc @stevieflow)

stevieflow commented 6 years ago

@BobHarper1 -- @morchickit thinks it might be better to have this a positive number, to flag up to people who publish -7 months, for example (which is happening)...

stevieflow commented 6 years ago

Also - @Bjwebb can we have dev version of CoVE for this branch?

cc/ @KDuerden

morchickit commented 6 years ago

We also discussed that it should be a float, not an integer. So this need to be a positive float (that can include zeros).

BobHarper1 commented 6 years ago

Agree on positive (set min to 0).

Does a float make sense to months? What is 0.5 of "a month"? For February, it's 14 days, for March 15.5...

Bjwebb commented 6 years ago

Here's a CoVE deploy for this dev branch http://branch-360-186-duration-number.cove-360-dev.default.threesixtygiving.uk0.bigv.io/

stevieflow commented 6 years ago

We should now merge this @Bjwebb