Duration (months) - "or an end date"

[stevieflow]

Whilst looking into https://github.com/ThreeSixtyGiving/standard/pull/238

Events or activities lasting more than one day should have either a duration (in months) or an end date.

@morchickit @KDuerden - Im guessing we dont really want/need a date in this field? @Bjwebb currently, is a date supported here - or is the description wrong?

[Bjwebb]

I think the description doesn't mean in this field (which isn't supported), but rather that you should have either "End Date" or "Duration (months). End Date has the same sentence in it: https://github.com/ThreeSixtyGiving/standard/issues/240

[stevieflow]

@morchickit @KDuerden shall we edit this?

[KDuerden]

Yes. Not sure how best to explain weeks/partial months - any suggestions?

"Events or activities lasting more than one day should have a duration. Duration should be in months, in number format."

[stevieflow]

Thanks

How about:

"The duration of the grant, in months. Must be in number format."

I'm minded that we should start to remove "should" references in the schema, and keep things simple. We might want to write wider guidance notes about how to implement dates and duration, for different types of grants.

[morchickit]

Sounds good to me

[KDuerden]

+1

[stevieflow]

OK - have created a PR on this specifically. I think the end date description would also need review/change. Ill do similar

[stevieflow]

One thing to flag - we have the schema for the summary tables:

https://github.com/ThreeSixtyGiving/standard/blob/master/schema/360-summary-table-schema.json

@Bjwebb just double checking, but I should make a similar PR on that?

[Bjwebb]

Yes, I think so.

[stevieflow]

Thanks @Bjwebb - have done that in PR #244

[stevieflow]

I think this now all in place