search

ThreeSixtyGiving / standard

The 360Giving data standard for UK philanthropic giving
http://www.threesixtygiving.org
Other
10 stars 15 forks source link

Additional fields false #248

Closed stevieflow closed 6 years ago

stevieflow commented 6 years ago

This work was committed by @BobHarper1 , adding an extra property to the schema. I can't locate an original issue to initiate this though.

@Bjwebb @timgdavies @kindly (and maybe @drkane & @morchickit) would you be able to review? Is this worth us getting into the planned tagged v1.0.0 release for the schema ( cc/ @morchickit )

Bjwebb commented 6 years ago

No, we don't want to merge this, it makes it impossible to add additional fields not in the schema.

I'm assuming this was made because its a useful way to do a bulk check for additional fields, I don't think this was ever meant to be merged,

stevieflow commented 6 years ago

Thanks @Bjwebb - should we delete the branch, too?

Bjwebb commented 6 years ago

Yes, have done. This is easy enough to recreate if someone wants it in future.