Closed stevieflow closed 1 year ago
@stevieflow How does this look?
Yes that looks great.
Perfect, thanks @Bjwebb
The (format) part of the uri shows, but with dates its says string, rather than date-time. https://standard.threesixtygiving.org/en/2021-package-metadata/reference/#id3
Is this automatic, or can that be configured?
@KDuerden This is automatic. The problem is that there's a "oneOf" in the schema (it can be date-time, or a date matching the given regex), so it dosen't know which to display. "Award Date" in the grants table has the same problem.
Thanks @Bjwebb
With this and https://github.com/ThreeSixtyGiving/standard/issues/293 also committed - could you take a look @KDuerden , and then schedule the review (ideally on the PR) with @drkane ?
Just realised we don't have a PR for the correct branch yet, so I've added that https://github.com/ThreeSixtyGiving/standard/pull/295
@Bjwebb I'm closing this as completed by #295 please re-open if necessary!
@Bjwebb to output a table for the Metadata / package schema here:
https://github.com/ThreeSixtyGiving/standard/blob/2021-package-metadata/documentation/reference.md#meta-sheet
@KDuerden this will be generated directly from the schema - so any mismatches with https://docs.google.com/document/d/1JcPA84zBwjN48k01gITkmAgSN24BJnLLyEc6Rh_eutc/edit#heading=h.ksut49wrb8nk would have to be remedied through schema edits (but I think all is fine)