search

ThreeSixtyGiving / standard

The 360Giving data standard for UK philanthropic giving
http://www.threesixtygiving.org
Other
10 stars 15 forks source link

Add new VES currency code #256

Closed Bjwebb closed 4 years ago

robredpath commented 6 years ago

Technically, this looks good. However, I don't know (and I can't see from the governance page of the docs what the requirements about a merge on to master are from a governance perspective.

morchickit commented 6 years ago

What issue does it answer? Was it just a minor bug?

On Tue, Aug 21, 2018 at 3:36 PM Rob Redpath notifications@github.com wrote:

Technically, this looks good. However, I don't know (and I can't see from the governance page of the docs http://standard.threesixtygiving.org/en/latest/governance/ what the requirements about a merge on to master are from a governance perspective.

— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub https://github.com/ThreeSixtyGiving/standard/pull/256#issuecomment-414696730, or mute the thread https://github.com/notifications/unsubscribe-auth/ADHzuwTGR3UEQEmgwlbaSGy2tHPzlWhCks5uTBr6gaJpZM4WFoZA .

Bjwebb commented 6 years ago

The change is just to add the VES code to our currency codelist. (Plus some reformatting that doesn't change meaning, due to putting the schema through a script).

We should add the code, because it has been added to the ISO 4217 list which we use.

morchickit commented 6 years ago

Then I think we can approve it without bother the Stewardship Committee. We should publish about it in the forum once it's live.

On Tue, Aug 21, 2018 at 5:48 PM Ben Webb notifications@github.com wrote:

The change is just to add the VES code to our currency codelist. (Plus some reformatting that doesn't change meaning, due to putting the schema through a script).

We should add the code, because it has been added to the ISO 4217 list which we use.

— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub https://github.com/ThreeSixtyGiving/standard/pull/256#issuecomment-414743089, or mute the thread https://github.com/notifications/unsubscribe-auth/ADHzu7fr-o58aZpjQd2Aa5M2SyDrsm7fks5uTDnbgaJpZM4WFoZA .

robredpath commented 4 years ago

Reviewed by @mrshll1001 and me today.

This is backwards-compatible bug fix, and so should go through the PATCH process.

drkane commented 4 years ago

Happy to approve.