search

ThreeSixtyGiving / standard

The 360Giving data standard for UK philanthropic giving
http://www.threesixtygiving.org
Other
10 stars 15 forks source link

Document mandatory fields #27

Closed practicalparticipation closed 9 years ago

practicalparticipation commented 9 years ago

We need to identify and document all mandatory fields in the standard.

pmackay commented 9 years ago

I notice the table schema (https://github.com/ThreeSixtyGiving/standard/blob/master/schema/summary-table/360-summary-table-schema.json) has required attributes but the JSON schema doesnt - would it be useful to transfer those across?

practicalparticipation commented 9 years ago

The JSON Schema at https://github.com/ThreeSixtyGiving/standard/blob/master/schema/360-giving-schema.json does include required elements. Was there somewhere else where it has fallen out of sync?

On Mon, Mar 16, 2015 at 8:48 AM, Paul Mackay notifications@github.com wrote:

I notice the table schema ( https://github.com/ThreeSixtyGiving/standard/blob/master/schema/summary-table/360-summary-table-schema.json) has required attributes but the JSON schema doesnt - would it be useful to transfer those across?

— Reply to this email directly or view it on GitHub https://github.com/ThreeSixtyGiving/standard/issues/27#issuecomment-81509148 .

w: http://www.timdavies.org.uk | m: 07834 856 303 | twitter: timdavies

Co-director of Practical Participation:

http://www.practicalparticipation.co.uk

Practical Participation Ltd is a registered company in England and Wales -

5381958.

pmackay commented 9 years ago

Ah, they're defined in separate arrays, was comparing where the required attribute is in each field object in the table schema.

What is remaining to complete on this issue then?

practicalparticipation commented 9 years ago

I think this might be covered now. Will close it.

On Mon, Mar 16, 2015 at 8:39 PM, Paul Mackay notifications@github.com wrote:

Ah, they're defined in separate arrays, was comparing where the required attribute is in each field object in the table schema.

What is remaining to complete on this issue then?

— Reply to this email directly or view it on GitHub https://github.com/ThreeSixtyGiving/standard/issues/27#issuecomment-81925847 .

w: http://www.timdavies.org.uk | m: 07834 856 303 | twitter: timdavies

Co-director of Practical Participation:

http://www.practicalparticipation.co.uk

Practical Participation Ltd is a registered company in England and Wales -

5381958.