search

ThreeSixtyGiving / standard

The 360Giving data standard for UK philanthropic giving
http://www.threesixtygiving.org
Other
10 stars 15 forks source link

Package metadata [WIP - do not merge] #272

Closed mrshll1001 closed 3 years ago

robredpath commented 4 years ago

Normative Metadata Documentation

robredpath commented 4 years ago

Normative Metadata Documentation

robredpath commented 4 years ago

Reviewed with @mrshll1001 today. This is getting close to being ready.

The change has been approved by the SC, so once this PR matches what the SC have asked us to do, we'll get this approved by 360, merged and released as a MINOR upgrade.

mrshll1001 commented 4 years ago

I've fixed the typos and addressed the points discussed.

I'll need support squashing the commits into a single commit, and then this needs reviewing.

KDuerden commented 4 years ago

Reviewed with @mrshll1001 today. This is getting close to being ready.

The change has been approved by the SC, so once this PR matches what the SC have asked us to do, we'll get this approved by 360, merged and released as a MINOR upgrade.

Discussing progress on this with @mrshll1001 this AM. We have made changes to the approved schema, and drafted normative text, does it not need a post on the forum to get sign off?

robredpath commented 4 years ago

@KDuerden I've had a fun delve into the governance docs and yes, you're right - it's not enough that we're carrying out what the SC asked us to, there is a definite stage on the flowchart where the actual schema and docs that will get merged need to be reviewed by the "standard governance group".

I think a bit of attention to our governance documentation wouldn't go amiss once we get 1.1 out!

KDuerden commented 4 years ago

great, thanks for checking and confirming. So as next steps, once you're all ready, I'll review in case there is anything further, then post on forum for approval, then we can merge. Is there going to be a branch that committee members will be looking at and I can point to the changes?

I think a bit of attention to our governance documentation wouldn't go amiss once we get 1.1 out!

Yes, next task after this is text review/house keeping!

robredpath commented 4 years ago

Is there going to be a branch that committee members will be looking at and I can point to the changes?

Yeah, we need to make a clean branch in this PR that makes the actual changes clear; @mrshll1001 do you want to put something in my calendar for us to go through this? Cleaning up git branches can be awkward, especially for very long-lived ones ("kindly and others added 19 commits on 12 Jul 2018 " O_o), so it might actually be easier to move the work over to a fresh branch and re-PR. Let's see when we talk.