Some of our recent readthedocs builds have been failing, and this became evident after changes from #370 were merged and didn't appear on the live docs site.
It appears to stem from some things inside conf.py, where a theme variable is only set when not inside the RTD environment.
I'm not sure on the details, but glancing at the pre-existing code and this guidance, it may be that the way to detect this may have changed?
This bugfix basically removes the conditional logic and imports the theme regardless of environment. The docs for the branch appear to build ok, but I'm not sure whether this change represents good practice for a conf.py file.
Please amend as needed, or merge in if this is OK.
Some of our recent readthedocs builds have been failing, and this became evident after changes from #370 were merged and didn't appear on the live docs site.
Error log for the build is here.
It appears to stem from some things inside
conf.py, where a theme variable is only set when not inside the RTD environment.I'm not sure on the details, but glancing at the pre-existing code and this guidance, it may be that the way to detect this may have changed?
This bugfix basically removes the conditional logic and imports the theme regardless of environment. The docs for the branch appear to build ok, but I'm not sure whether this change represents good practice for a
conf.pyfile.Please amend as needed, or merge in if this is OK.