search

ThreeSixtyGiving / standard

The 360Giving data standard for UK philanthropic giving
http://www.threesixtygiving.org
Other
10 stars 15 forks source link

Spreadsheet templates - ocid field #46

Closed stevieflow closed 9 years ago

stevieflow commented 9 years ago

Is there a mix up with OCDS in the tabs/sheets in the data templates? There are labelled as ocid, which I assume is "Open Contracting ID"?

stevieflow commented 9 years ago

eg: https://github.com/ThreeSixtyGiving/standard/blob/master/schema/summary-table/360-giving-schema-titles.csv/Location.csv

practicalparticipation commented 9 years ago

Yes - this is a bug in the template generation. Will look into it...

practicalparticipation commented 9 years ago

Need to discuss with @bjwebb and fix by end of week.

Bjwebb commented 9 years ago

Thanks for pointing this out for me, I've discussed this issue with @stevieflow separately, hadn't realised it affected this repo. Basically the issue is that you haven't specified --root-id='' which would cause the ocid columns to be omitted. However, this is because it was also missing from the example in the README. I've now fixed this - https://github.com/open-contracting/flattening-ocds/commit/a500bbb0e9e6cef98d74b00120874d0dd5701457

If you try again with the updated command the problem should be resolved.