ThreeSixtyGiving / standard

The 360Giving data standard for UK philanthropic giving
http://www.threesixtygiving.org
Other
10 stars 15 forks source link

Publications with grants that have one Classification #66

Closed stevieflow closed 8 years ago

stevieflow commented 9 years ago

If/when a grant has one classification code per grant , the documentation seems to suggest that this should be a separate table:

http://www.threesixtygiving.org/standard/reference/#toc3

To provide classifications of grants, more than one location, or additional documents related to the grant, you will need to publish information in sub-tables.

However - in this use case, could a single classification sit in the Grants Sheet?

timgdavies commented 9 years ago

Yes. See http://www.threesixtygiving.org/standard/reference/#toc15

Adding fields for

Classification:Vocabulary Classification:Code Classification:Title

should be possible, although there might be some tweaks to the flatten tool/cove required before the conversion of that to JSON works properly (can you test and liase with Ben on the changes required and when they are scheduled)

stevieflow commented 9 years ago

Great, thanks @timdavies - makes sense

stevieflow commented 9 years ago

@Bjwebb how best to proceed?

stevieflow commented 8 years ago

@bjwebb @kindly @caprenter I think this is still the case? A single Classification cannot be published in the grant sheet?

cc @ekoner

timgdavies commented 8 years ago

This is definitely one of the things that I hope gets sorted with flatten tool developments coming up...

Bjwebb commented 8 years ago

Yes, I think this is this issue again https://github.com/OpenDataServices/flatten-tool/issues/50 ? Definitely planning to get this one cracked next week.

Bjwebb commented 8 years ago

The rollup titles bug is now fixed in flattentool, see the commits against https://github.com/OpenDataServices/flatten-tool/issues/50 . This is now available for testing at http://flatten-tool-updates.dev.cove.opendataservices.coop/360/

Note that the appropriate fields are actually currently:

Classifications:Vocabulary Classifications:Code Classifications:Title

ie. the plural Classifications rather than Classification, as the former is the title in the schema.

I think is the correct behaviour, so will close this this issue for now.