ThreeTAG / Palladium

GNU General Public License v3.0
14 stars 11 forks source link

Incompatibility with Mini Tardis #108

Closed GrayStriped closed 8 months ago

GrayStriped commented 8 months ago

Installing Palladium prevents resources for the mod "Mini Tardis" from loading. Specifically, Minecraft will say "Resource reload failed". Pictures attached are with and without Palladium. 2024-03-18_22 17 19 2024-03-18_22 19 02

PierogiPL commented 8 months ago

Does that happen with just Palladium? Based on testing I did, it was that one KubeJS dependency that caused it.

Lucraft commented 8 months ago

Can you send a log file with Mini Tardis and Palladium installed?

GrayStriped commented 8 months ago

latest.log

The only installed mods are Mini Tardis, Palladium, Fabric API, and JEI

GrayStriped commented 8 months ago

Does that happen with just Palladium? Based on testing I did, it was that one KubeJS dependency that caused it.

The problem persists without KubeJS

Lucraft commented 8 months ago

This issue comes from Mini Tardis, well, their lib mod. They add "silly hears" model parts to all player models, and when it cant be found in Palladium's models it causes issues. Would be something that they have to fix/change. https://github.com/enjarai/cicada-lib/blob/master/src/main/java/nl/enjarai/cicada/mixin/PlayerEntityModelMixin.java

enjarai commented 8 months ago

I can tell that that's the root cause here, but why is adding a modelpart problematic for your library, and how would I work around that? The way I'm adding the modelpart should be exactly the same as how vanilla does it, or am I missing something here?

Lucraft commented 8 months ago

I think you could try adding a try-catch block around the "root.getChild()" method-calls, and then consider the sillyHairsLeft/-Right fields null in the further code. The problem is that you mixin into the vanilla player model, so every mod that will use this class and provide a fully-custom model-layer to it will crash, since their model-layer doesnt have those parts in them

enjarai commented 8 months ago

Hmm I see, that seems like a good approach, I'll implement that soon™. Thanks for helping figure this out, I was honestly quite confused.