search

ThreeTen / threeten

This project was the home of code used to develop a modern date and time library for JDK8. Development has moved to OpenJDK and a separate backport project, threetenbp.
http://threeten.github.io/
191 stars 37 forks source link

Rename Instant.toEpochMilli to toEpochMillis #300

Closed RogerRiggs closed 11 years ago

RogerRiggs commented 11 years ago

It was observed that in most methods in 310 and in the JDK the names of methods use "millis" and not "milli". See Clock, Duration, etc for examples. Rename toEpochMilli and ofEpochMilli to use the plural.

jodastephen commented 11 years ago

This was deliberate. We also have LocalDate.ofEpochDay, LocalTime.ofNanoOfDay, LocalTime.ofSecondOfDay, LocalDateTime.ofEpochSecond and Instant.ofEpochSecond.

In general, we use singular for fields and plural for units.

I don't overly mind changing, but we'd have to identify every last case that needs changing for consistency.

RogerRiggs commented 11 years ago

The motivation to change is not compelling and it would cause other changes. The current approach is self consistent and deliberate. Leave it as is.