search

ThreeTen / threeten

This project was the home of code used to develop a modern date and time library for JDK8. Development has moved to OpenJDK and a separate backport project, threetenbp.
http://threeten.github.io/
191 stars 37 forks source link

Correct localization of Hijrah Chronology #309

Closed RogerRiggs closed 10 years ago

RogerRiggs commented 11 years ago

The Hijrah Chronology reports its name as "Hijrah-umalqura" from the DateTimeFormatter. Since this is the default and was been identified as the primary Hijrah Calendar it should return the name "Hijrah". The chronology has/should have an alias "islamic" that can be used for lookup. An alias "Hijrah-umalqura" is not necessary. Note that the chronology type "islamic-umalqura" also refers to this chronology and can be used for lookup. There is no localization data for "islamic-umalqura" so the raw calendarType is returned.

jodastephen commented 11 years ago

My note was that the other calendar systems had a name in English of "Foo Calendar". Where that came from and how correct it was isn't really up to me, but Hijrah looked an odd one out.

RogerRiggs commented 11 years ago

The localized Calendar names come from CLDR data and CLDR has no data for the calendarType "islamic-umalqura" so the raw calendar type is returned. Either data is needed or a defaulting mechanism to revert to just "islamic" to do the locale lookup.

jodastephen commented 11 years ago

I think the lookup should be try to get something for "islamic-umalqura", if that fails then try "islamic". I think thats what the CLDR document suggests anyway.

RogerRiggs commented 11 years ago

JBS/bugs.sun.com 8015986

dchiba commented 11 years ago

In the CLDR survey tool, Arabic translation seems available now: http://st.unicode.org/cldr-apps/v#/ar/Keys/38c24f0080185f57

It has a warning for the parenthesis. I got a proposed Arabic string without ( ) from an Arabic speaker. I wanted to enter it to the survey issue but had a authentication issue. I tried the password recovery but not receiving the recovery email although the system appears to have sent one. If anybody has a good account at the CLDR site and could upload the proposed solution of the warning, please let me know.

jodastephen commented 11 years ago

There is a Unicode mailing list, although tech support questions probably wouldn't be applicable.

dchiba commented 11 years ago

Submitted a request for assistance to the site admin contact form.

dchiba commented 11 years ago

Acquired access to CLDR and submitted strings proposed by our native Arabic expert.

According to him, the current proposed string says "Islamic calendar [Umm al-Qura]" and this is inconsistent with the string for islamic-calendar that says "Hijrah calendar". The translation of "Islamic calendar" is "Hijrah calendar" so all of islamic-calendar-* should consistently say "Hijrah calendar [*]".

RogerRiggs commented 11 years ago

JBS mirror is bugs.sun.com http://bugs.sun.com/view_bug.do?bug_id=8015986

RogerRiggs commented 10 years ago

Resolved by: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0beaa65c90c8