search

ThreeTen / threetenbp

Backport of functionality based on JSR-310 to Java SE 6 and 7. This is NOT an implementation of JSR-310.
http://www.threeten.org/threetenbp/
BSD 3-Clause "New" or "Revised" License
551 stars 139 forks source link

Islamic date is not same as Threeten #66

Closed sw926 closed 7 years ago

sw926 commented 7 years ago 
org.threeten.bp.chrono.HijrahDate hijrahDate = org.threeten.bp.chrono.HijrahDate.now();
System.out.println(hijrahDate);

HijrahDate date = HijrahDate.now();
System.out.println(date);

outputs:

Hijrah-umalqura AH 1438-08-15
Hijrah-umalqura AH 1438-08-16
tynn commented 2 years ago

I think this is still an issue related to the length of months.

Today I found Hijrah-umalqura AH 1442-01-30 which should not exist.

For me it seems like HijrahDate.MONTH_LENGTH is too much of a simplification as this seems to change year to year.

@jodastephen maybe this issue should be reopened.