ThreeTen22 / skyrim-plugin-decoding-project

Automatically exported from code.google.com/p/skyrim-plugin-decoding-project
1 stars 0 forks source link

Changing FormID of Region causes severe bugs. #121

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Change FormID on a Region (REGN).
2. Select All records in the Referenced by List.
3. View number of records changed not equal to number of referenced by records.

What is the expected output?

x(all) number of x(all) number references changed from to new FormID from old 
FormID.

What do you see instead?

x(0 or not equal to all) number of x(all) references changed from to new FormID 
from old FormID.

What version of the product are you using? On what operating system?

3.0.28 Windows 7 64x.

Please provide any additional information below.

This severe bug seems to be random. When changing the FormID of the REGN, the 
program correctly counts and lists the cells or references that use the region, 
but when the entire list or some of the list is selected, the program fails to 
update those records. Worse still, it will remove that information from those 
records, completely unreferencing the region in the process. On some Regions, 
it will change some or most of the records that were selected, but fail on the 
rest and remove that information from those records. There seems to be no 
pattern. It can fail on a record only referenced by 4 cells, or one referenced 
by 2500 cells. I haven't seen the process work fully so I can rule out that it 
will work once in a while.

Now, using the command Change Referencing Records will work completely. But 
this forces people to duplicate the Region with the FormID they want and then 
use the Change Referencing Records command. It is a workaround but it is two 
more steps that shouldn't have to be taken to simply change the Region, and its 
references, FormID.

Original issue reported on code.google.com by harkness...@yahoo.com on 5 Mar 2013 at 10:45

GoogleCodeExporter commented 9 years ago
Confirmed on Dragonborn.esm using latest 3.0.29
Changing FormID of WeatherDLC2SolstheimSnow [REGN:02029F3B] to any value does 
not update cell 0200EC43 (and another one), but removes XCLR - Regions 
completely from them.

Original comment by zila...@gmail.com on 6 Mar 2013 at 5:49

GoogleCodeExporter commented 9 years ago
It looks like the code in wbCELLAfterLoad to remove XCLR record from non region 
reference is the culprit. This would also be a LinksTo/BuildRef problem like 
issue 118.

Original comment by HuguesLe...@gmail.com on 6 Mar 2013 at 10:50

GoogleCodeExporter commented 9 years ago
XCLR removal is unchanged from FNV, actually I don't see any point in fixing 
broken regn links from CELL by xEdit. Maybe just disable it?

Original comment by zila...@gmail.com on 6 Mar 2013 at 11:16

GoogleCodeExporter commented 9 years ago
Yes I saw. If I comment it, no more issue BUT that does not explains why 
LinksTo does not "link".
Plus I have to find WHY this was required in Oblivion. That is where the patch 
was introduced.

Original comment by HuguesLe...@gmail.com on 6 Mar 2013 at 12:27

GoogleCodeExporter commented 9 years ago
I can confirm LinksTo does not work on the reference being changed. I have to 
block BuildRef until all records are updated, and then find them again.
Meanwhile, I am commenting the XLCR paragraph in wbCELLAfterLoad FO3, FNV and 
TES5.
We need Arthmoor take on if it is useful in TES4.

Meeting time now...

Original comment by HuguesLe...@gmail.com on 6 Mar 2013 at 1:00

GoogleCodeExporter commented 9 years ago
Tested in TES4Edit.
Copied Oblvion.esm to another file, loaded both, added Oblvion.esm as a master, 
changed some formdis, saved (that took long, 1.2m+ of records), loaded back in 
TES4Edit. Everything is fine so far.

Original comment by zila...@gmail.com on 6 Mar 2013 at 5:35

GoogleCodeExporter commented 9 years ago
That was with disabled XCLR removal.

Original comment by zila...@gmail.com on 6 Mar 2013 at 5:36

GoogleCodeExporter commented 9 years ago

Original comment by zila...@gmail.com on 11 Mar 2013 at 4:43