search

ThreeTen22 / skyrim-plugin-decoding-project

Automatically exported from code.google.com/p/skyrim-plugin-decoding-project
1 stars 0 forks source link

Adding items to a leveled list does not increase LLCT count. #69

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?
1. Navigate to any leveled item entry.
2. Copy as override to a new plugin.
3. Attempt to add a new item to the overridden list.

What is the expected output?
The count should increment on the LLCT subrecord to indicate a new item was 
added to the list.

What do you see instead?
LLCT remains unchanged and must be incremented manually.

Original issue reported on code.google.com by arthmoor on 16 Oct 2012 at 6:26

GoogleCodeExporter commented 9 years ago 
The same is likely true of adding an entry to a leveled NPC list as well.

Original comment by arthmoor on 16 Oct 2012 at 6:28

GoogleCodeExporter commented 9 years ago 
There are other counters like SPCT for spells, COCT for items and KSIZ for 
keywords.
Unfortunately xedit doesn't have callbacks when manipulating arrays, only for 
single values. So all I can do is attach a hook to LLCT, COCT, SPCT, KSIZ and 
autoset their values when you try to modify them.
How about this?

Original comment by zila...@gmail.com on 16 Oct 2012 at 9:00

GoogleCodeExporter commented 9 years ago 
I mentioned some of the counts that need to be updated in issue51 which was 
closed, but I see now that the issue was with callbacks.  I would think there 
would have been counts for arrays for other versions like FO3/FNV/TES4Edit that 
would need updated.  Do they update?  If so how?

Original comment by danielhmpdx16@gmail.com on 16 Oct 2012 at 2:37

GoogleCodeExporter commented 9 years ago 
Does this happen in wbImplementation.pas or wbInterface.pas?

Original comment by danielhmpdx16@gmail.com on 16 Oct 2012 at 2:39

GoogleCodeExporter commented 9 years ago 
There are no counts in previous games.
I tested dynamic update of counts when assigning them a value, but it has some 
drawbacks. The safe way is to update them manually unfortunately.

Original comment by zila...@gmail.com on 16 Oct 2012 at 2:56

GoogleCodeExporter commented 9 years ago 
Ohhh, yeah, okay that's fine then.  As long as people know and it's in the html 
documentation, and on the CK Wiki then that's reasonable.  Maybe Elminster can 
change that when he gets a chance.  Thanks for the explination.

Original comment by danielhmpdx16@gmail.com on 16 Oct 2012 at 3:06

GoogleCodeExporter commented 9 years ago 
That's probably why Elminster told me to mark the source code with comments 
where counts need to be updated.  He said that would have to be added, but he 
didn't explain why.

Original comment by danielhmpdx16@gmail.com on 16 Oct 2012 at 3:08

GoogleCodeExporter commented 9 years ago 
[deleted comment]
GoogleCodeExporter commented 9 years ago 
I wouldn't mark is as "wontfix" if you're wanting Elminster to use the 
information here. Rather, just leave it open and he can read the comments etc.

Original comment by arthmoor on 16 Oct 2012 at 8:27

GoogleCodeExporter commented 9 years ago 
[deleted comment]
GoogleCodeExporter commented 9 years ago 
Issue 51 has been merged into this issue.

Original comment by danielhmpdx16@gmail.com on 18 Oct 2012 at 8:10

GoogleCodeExporter commented 9 years ago 
I wrote a simple script that does this. Maybe such a script could just be 
included, or even built into the menu structure?

Original comment by dfrau...@gmail.com on 15 Mar 2013 at 5:33

GoogleCodeExporter commented 9 years ago 
Well thats a start thanks. I am working on this but I don't expect a valid 
version for next release.

Original comment by HuguesLe...@gmail.com on 15 Mar 2013 at 5:46

GoogleCodeExporter commented 9 years ago 
Started in the experimental branch but this version is game specific and only 
applies to some counter. Zilav suggested a switch to Callback, but there are 
none currently for some of the types involved.

Maybe I'll wait to see what Beth do with FO4 :)

Original comment by HuguesLe...@gmail.com on 5 Jul 2013 at 2:20

GoogleCodeExporter commented 9 years ago 
Zilav, I'd like your opinion on r1498 :)

Original comment by HuguesLe...@gmail.com on 8 Jan 2014 at 11:04

GoogleCodeExporter commented 9 years ago 
Waiting for 2015 seems like an awful long time :P

Original comment by arthmoor on 9 Jan 2014 at 12:40

GoogleCodeExporter commented 9 years ago 
Added counters:
    SPCT, KSIZ, LLCT, PRKZ, CITC, IDLC

Anybody knows where IDLC is used in vanilla package (FO3, FNV or TES5) ?

Original comment by HuguesLe...@gmail.com on 15 Jan 2014 at 10:58

GoogleCodeExporter commented 9 years ago 
What's an IDLC supposed to do? If it wasn't in any vanilla packages how did it 
get discovered?

Original comment by arthmoor on 15 Jan 2014 at 11:44

GoogleCodeExporter commented 9 years ago 
It's an Idle Count for IDLM and and it's part of Pack.

Original comment by danielhmpdx16@gmail.com on 16 Jan 2014 at 1:30

GoogleCodeExporter commented 9 years ago 
Probably got discovered adding something to the record in the CK that increased 
the count.  When we did decoding that's how you figured it out.  Just make a 
change in the CK and dump it using Dump.

Original comment by danielhmpdx16@gmail.com on 16 Jan 2014 at 1:31

GoogleCodeExporter commented 9 years ago 
Package MQSkyHavenEsbernRead22x6 has two idles on it so that should do the 
trick I'd think?

Original comment by arthmoor on 16 Jan 2014 at 1:45

GoogleCodeExporter commented 9 years ago 
Thanks. Corrected version uploaded.
Still to do:
  Other counters ?
  Avoid recalculating all counters during load, because that silently corrects them without marking the plugin as modified.

Original comment by HuguesLe...@gmail.com on 16 Jan 2014 at 9:25

GoogleCodeExporter commented 9 years ago 
Should be done in the Exp branch. Let me know if I forgot some counters.

Original comment by HuguesLe...@gmail.com on 18 Jan 2014 at 6:39

GoogleCodeExporter commented 9 years ago 
Fixed as of r1510 normally.

Original comment by HuguesLe...@gmail.com on 19 Jan 2014 at 1:36

GoogleCodeExporter commented 9 years ago

Original comment by HuguesLe...@gmail.com on 3 Jun 2014 at 6:11

GoogleCodeExporter commented 9 years ago

Original comment by HuguesLe...@gmail.com on 3 Jun 2014 at 6:16