ThreeTen22 / skyrim-plugin-decoding-project

Automatically exported from code.google.com/p/skyrim-plugin-decoding-project
1 stars 0 forks source link

Incorrect error information is displayed when using "check for errors". #70

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Load Open Cities Skyrim.esp
2. Run "check for errors"
3. Observe the output - most or all of that are valid constructs

What is the expected output?
No errors should be thrown.

What do you see instead?
A sea of incorrectly reported errors.

What version of the product are you using? On what operating system?
Version 3.0.23 (yes, this is the correct version number)
Win 7 x64 etc.

Please provide any additional information below.

Folks are beginning to use this information to construct lists of "bad" mods, 
which in itself is not a bad thing, but it's negligent when the output is 
clearly not understood based on actual CK data. So these errors need to be 
reported accurately.

Examples:

[00:00]         Keyword -> Found a NULL reference, expected: KYWD
[00:00]       Above errors were found in :KWDA - Keywords
[00:00]     Above errors were found in :SolitudeDocksLocation "Solitude" 
[LCTN:000358B9]
[00:00]   Above errors were found in :GRUP Top "LCTN"

A NULL KYWD attached to LCTN is acceptable when there are no keywords.

[00:00]                 NAME - Projectile -> Found a HAZD reference, expected: 
PROJ
[00:00]               Above errors were found in :[PHZD:0200C473] (places 
FireLgPlacedHazard "Fire" [HAZD:00057A8C] in GRUP Cell Temporary Children of 
SolitudeExterior02 [CELL:0000927A] (in Tamriel "Skyrim" [WRLD:0000003C] at 
-16,25))

A HAZD reference is perfectly acceptable. Every city has dozens of these. They 
are large orange squares which produce fire effects that damage the player if 
walked through.

[00:03]         Keyword -> Found a NULL reference, expected: KYWD
[00:03]       Above errors were found in :KWDA - Keywords
[00:03]     Above errors were found in :OCSTenalJalzei "Tenal-Jalzei" 
[NPC_:02001D53]

The lack of keywords on an NPC_ record is valid, that's how the CK represents 
there not being any.

There may be other false cases, I will post them in followup comments as I find 
them.

Original issue reported on code.google.com by arthmoor on 18 Oct 2012 at 6:05

Attachments:

GoogleCodeExporter commented 9 years ago
Ok, I'll save some time here. It looks like there's a vast number of various 
records where Edit reports a NULL KYWD subrecord as invalid. This is not the 
case. A NULL KYWD is acceptable and expected.

Original comment by arthmoor on 18 Oct 2012 at 6:21

GoogleCodeExporter commented 9 years ago
Fixed.

Original comment by zila...@gmail.com on 18 Oct 2012 at 7:36

GoogleCodeExporter commented 9 years ago
Just to be clear, that also included the HAZD fix, yes?

Original comment by arthmoor on 19 Oct 2012 at 6:03

GoogleCodeExporter commented 9 years ago
I added HAZD as an allowed FormID for PHZD PGRE PARW PBAR PBEA PCON PFLA.

Original comment by zila...@gmail.com on 19 Oct 2012 at 6:08