search

Threespot / tolaria

A Rails CMS framework for making your editors happy.
https://threespot.github.io/tolaria/
MIT License
37 stars 5 forks source link

Stop using inline styles (because CSP) #56

Open csuhta opened 8 years ago

csuhta commented 8 years ago

Some Tolaria features (the login form, a few of the JS form elements) use inline CSS styles, which preclude you from using the admin with a Content-Security-Policy unless you set the undesirable 'unsafe-inline' directive.

Refactor the UI elements so that they use CSS classes to manage their appearance, rather than inline styles. As a warning: we also have to move away from jQuery's hide() and show() because those use inline styles.

defbyte commented 8 years ago

Will there be backwards incompatible changes introduced? For example, I know of a project where we customized the Markdown editor, adding new toolbar buttons and stuff. Just wondering, thanks!

csuhta commented 8 years ago

@defbyte Very likely. This will probably be part of Tolaria 3.0 or higher.