search

Thriftpy / thriftpy

Thriftpy has been deprecated, please migrate to https://github.com/Thriftpy/thriftpy2
MIT License
1.15k stars 286 forks source link

Support implicit field keys #319

Open jparise opened 6 years ago

jparise commented 6 years ago

Fields without explicit keys are automatically assigned starting from -1 and working their way down. Implicit field keys are deprecated by Apache Thrift, but supporting them gives us greater Thrift IDL compatibility.

jparise commented 6 years ago

@maralla and @hit9, do you think this is something you'd consider for review and merging? It's an old Thrift feature, but we have some .thrift files that rely on it, and we unfortunately can't just add the explicit negative key values to the IDL files without triggering other warnings.

jparise commented 6 years ago

@maralla and @hit9, just wanted to follow-up and ask if this is still under consideration.

jparise commented 6 years ago

Sorry to bother @lxyu @hit9 @maralla, but would you consider merging this?