search

Thriftpy / thriftpy

Thriftpy has been deprecated, please migrate to https://github.com/Thriftpy/thriftpy2
MIT License
1.15k stars 286 forks source link

Confused with absulute path in windows #341

Open kep-w opened 6 years ago

kep-w commented 6 years ago

https://github.com/eleme/thriftpy/blob/c49a3adf2c52948b5c1a01c3109c9676763095f0/thriftpy/parser/parser.py#L547

hi, I am using the thriftpy in our project, our environment is Windows, and when i use thriftpy.load(path, ....) function. the question is if use relative path as the path argument, it will raise an IOError, told that do not have the file. But, if I change absulute path, after urlparse, the scheme is 'c'/'d'/'e', and the judgment here will not be matched. So why is the judgment here not changed to be able to adapt to the absolute path in windows? My suggestion is: elif len(url_scheme) <= 1:

ethe commented 5 years ago

Have already been solved in thriftpy2, thanks.