Thriftpy / thriftpy2

Pure python approach of Apache Thrift.
MIT License
572 stars 91 forks source link

Include tests in the sdist tarball on pypi #114

Closed scarabeusiv closed 4 years ago

scarabeusiv commented 4 years ago

If a vendor wants to validate the thriftpy2 against his python stack this allows him to use the pypi archive instead of relying on github tags.

codecov[bot] commented 4 years ago

Codecov Report

Merging #114 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #114   +/-   ##
======================================
  Coverage    79.7%   79.7%           
======================================
  Files          43      43           
  Lines        3902    3902           
======================================
  Hits         3110    3110           
  Misses        792     792

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8ace4be...44398fe. Read the comment docs.

ethe commented 4 years ago

I checked other libraries such as flask and redis-py, they do not pack their test cases in their package, could you please tell me your primary demand?

scarabeusiv commented 4 years ago

We use this to execute tests on distribution side, i.e. the package that Debian/Fedora/SUSE ships we take from pypi and also execute the tests to see if it works.

See example buildlog of pytest-testconfig package: pytest-buildlog.txt

aiudirog commented 4 years ago

The tests package is already excluded setup.py under find_packages so the manifest change would only include them in the sdist. To me, that makes sense because anyone building from source is probably going to want to run the tests, but someone installing a wheel probably won't.

ethe commented 4 years ago

I got it, thank you.