Rename socket_timeout to timeout for compatibility

[aiudirog]

The standard make_client() uses the timeout argument to specify the socket timeout whereas the asyncio make_client() calls it socket_timeout. Since AIOHappyBase handles both, it leads to awkward dispatch issue where I have to rewrite the argument for one.

This PR deprecates socket_timeout in favor of just timeout so that the async make_client() matches the standard one. I chose this and not the other way around so it would have the least impact on existing code, even though the socket_timeout name is more descriptive and probably better.

[codecov[bot]]

Codecov Report

Merging #115 into master will increase coverage by 0.01%. The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #115      +/-   ##
==========================================
+ Coverage    79.7%   79.71%   +0.01%     
==========================================
  Files          43       43              
  Lines        3902     3905       +3     
==========================================
+ Hits         3110     3113       +3     
  Misses        792      792

Impacted Files	Coverage Δ
thriftpy2/contrib/aio/rpc.py	84.44% <100%> (+1.11%)	:arrow_up:

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 82d5a79...5bd4ef4. Read the comment docs.

[aisk]

Maybe a little test case on this should be cool?

[aiudirog]

@aisk I mocked out TAsyncSocket and validated that the arguments are handled as expected. I also squashed the commits since I had some small hiccups with flake8 and Py3.5.

[aisk]

Great job 👍 LGTM

[aiudirog]

I'll go ahead and merge this in. Thanks!

[ethe]

👍 good job