Thriftpy / thriftpy2

Pure python approach of Apache Thrift.
MIT License
572 stars 91 forks source link

Fix exception handling in TProcessor #128

Closed microdog closed 4 years ago

microdog commented 4 years ago

This fixes the issue that exceptions may be dropped silently in TProcessor. The issue was introduced in https://github.com/Thriftpy/thriftpy2/pull/4.

codecov[bot] commented 4 years ago

Codecov Report

Merging #128 into master will increase coverage by 3.39%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #128      +/-   ##
==========================================
+ Coverage   79.71%   83.11%   +3.39%     
==========================================
  Files          43       43              
  Lines        3905     3908       +3     
==========================================
+ Hits         3113     3248     +135     
+ Misses        792      660     -132
Impacted Files Coverage Δ
thriftpy2/contrib/aio/processor.py 84.31% <100%> (+2.31%) :arrow_up:
thriftpy2/contrib/tracking/__init__.py 96.45% <100%> (+35.73%) :arrow_up:
thriftpy2/tornado.py 85.18% <100%> (+2.57%) :arrow_up:
thriftpy2/contrib/aio/socket.py 78.02% <0%> (+0.54%) :arrow_up:
thriftpy2/contrib/tracking/tracker.py 86.73% <0%> (+8.16%) :arrow_up:
thriftpy2/http.py 87.35% <0%> (+8.62%) :arrow_up:
thriftpy2/thrift.py 88.88% <0%> (+11.82%) :arrow_up:
thriftpy2/server.py 64.86% <0%> (+27.02%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b78720e...140854e. Read the comment docs.

ethe commented 4 years ago

LGTM