Thriftpy / thriftpy2

Pure python approach of Apache Thrift.
MIT License
572 stars 91 forks source link

mixed up binary and string types #136

Closed vitrun closed 3 years ago

vitrun commented 4 years ago

why does thriftpy2 treat binary as string?

in thrift.py:

    STRING = 11
    UTF7 = 11
    BINARY = 11  # This here just for parsing. For all purposes, it's a string

this may cause inconvenience when sending files, images, etc.

ethe commented 4 years ago

There is no difference between string and binary in Python 2, so it is not be considered before.

ethe commented 3 years ago

Close via #139