search

Thriftpy / thriftpy2

Pure python approach of Apache Thrift.
MIT License
572 stars 91 forks source link

fix multi level module #141

Closed windard closed 4 years ago

windard commented 4 years ago

Change-Id: I59002abfd3d2dd5665ddee8a6a12d1513f15758a

codecov[bot] commented 4 years ago

Codecov Report

Merging #141 into master will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #141   +/-   ##
=======================================
  Coverage   83.14%   83.14%           
=======================================
  Files          43       43           
  Lines        3921     3921           
=======================================
  Hits         3260     3260           
  Misses        661      661
Impacted Files Coverage Δ
thriftpy2/parser/parser.py 95.57% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a8b7873...517d64c. Read the comment docs.

aisk commented 4 years ago

@windard do you have any related issue for this PR? And I think it should be cool if there was a test case for we don't break the behavior in this PR in the future.

windard commented 4 years ago

yeah, it has been fixed, but not released. let's close this PR. https://github.com/Thriftpy/thriftpy2/pull/125