search

Thriftpy / thriftpy2

Pure python approach of Apache Thrift.
MIT License
572 stars 91 forks source link

add support for custom headers for HTTP #149

Closed ermeaney closed 3 years ago

ermeaney commented 3 years ago

Our thrift implementation needs to have some custom headers in the HTTP call, and since the implementation was almost there I updated the make_client function to support it

codecov[bot] commented 3 years ago

Codecov Report

Merging #149 (1d951c5) into master (faf1055) will increase coverage by 0.07%. The diff coverage is 93.75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #149      +/-   ##
==========================================
+ Coverage   84.05%   84.13%   +0.07%     
==========================================
  Files          44       44              
  Lines        4133     4141       +8     
==========================================
+ Hits         3474     3484      +10     
+ Misses        659      657       -2
Impacted Files Coverage Δ
thriftpy2/http.py 88.64% <93.75%> (+1.64%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update faf1055...1d951c5. Read the comment docs.

ethe commented 3 years ago

Hi, please add a test case to this feature, thanks.

aisk commented 3 years ago

LGTM, approved, thanks for the contribution @ermeaney !

But I saw there was a conflict, I think you should rebase the commits so we can merge it.