search

Thriftpy / thriftpy2

Pure python approach of Apache Thrift.
MIT License
572 stars 91 forks source link

WIP: translate socket.timeout to TTransportException #160

Open aisk opened 3 years ago

aisk commented 3 years ago

So we can get better error message for which ip / port is called.

aisk commented 3 years ago

Seems the test cases are excepecting error socket.timeout, so this will be a breaking change?

codecov[bot] commented 3 years ago

Codecov Report

Merging #160 (efede5f) into master (108cca5) will decrease coverage by 0.28%. The diff coverage is 42.10%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #160      +/-   ##
==========================================
- Coverage   83.35%   83.06%   -0.29%     
==========================================
  Files          43       43              
  Lines        3935     3951      +16     
==========================================
+ Hits         3280     3282       +2     
- Misses        655      669      +14
Impacted Files Coverage Δ
thriftpy2/transport/sslsocket.py 89.58% <ø> (ø)
thriftpy2/transport/socket.py 84.35% <41.17%> (-8.78%) :arrow_down:
thriftpy2/rpc.py 81.94% <50.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 108cca5...efede5f. Read the comment docs.