Closed pabfuentes closed 7 months ago
The recent updates involve the introduction of a new foo_union
in a Thrift annotations file, which includes boolean and integer fields. Additionally, the thriftpy2
library's parser logic has been enhanced to accommodate type annotations for unions within the Thrift specification, refining the way unions are parsed and interpreted.
Files | Change Summaries |
---|---|
tests/parser-cases/.../annotations.thrift |
Added a foo_union with bool and i32 fields. |
thriftpy2/parser/parser.py |
Modified union rule to include type_annotations . |
🐇✨
In a world of code, changes are afoot,
A union anew, with fields so astute.
Parsing with care, annotations in sight,
A rabbit's delight, in the moonlight.
🌕🎉
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
LGTM, I'll merge this a few days later if other reviewers have no issues with this change. Thanks for your contribution!
LGTM
fix: support annotations in union
Summary by CodeRabbit