Closed aisk closed 6 months ago
The update involves refining the naming convention for setup and teardown methods within a test class, aiming to enhance consistency and readability. These adjustments signify a shift towards a more standardized approach in managing test preparations and conclusions. Additionally, a modification in test_rpc.py
removes a deprecated warning related to client instantiation with a timeout value.
File Path | Changes |
---|---|
tests/test_aio.py |
Renamed setup to setup_method , and teardown_ to teardown_method in TestDeprecatedTimeoutKwarg class. |
tests/test_rpc.py |
Modified test_client_timeout function to address a deprecated warning in client instantiation. |
🐇✨
In the realm of code, where tests quietly lay,
A rabbit hopped through, making changes today.
"Setup to setupmethod, teardown shall mend,
For consistency's sake, until the very end."
With each hop and leap, the code did transform,
In the tests' quiet world, now more uniform. 🌟🐾
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Since this is a trival change which keeps the CI healthy, I'll merge it after the CI passed. cc @ethe
Details:
About the change in the
test_rpc.py
, see the comment below.Summary by CodeRabbit
Summary by CodeRabbit
test_client_timeout
function related to client instantiation.