Closed aisk closed 4 months ago
The recent updates focus on simplifying the test suite and enhancing Python version compatibility within the library. By removing unnecessary imports and version-specific conditions, the changes streamline the testing process. Additionally, the modifications to ThriftImporter
and ThriftLoader
classes, along with the removal of conditional checks for Windows and Python version in the parser, aim to improve the library's adaptability across different Python environments.
Files | Change Summary |
---|---|
tests/conftest.py |
Removed sys import and conditional test exclusion. |
tests/test_framed_transport.py tests/test_tornado.py |
Removed sys and pytest imports, eliminated pytest.mark.skipif decorators. |
thriftpy2/hook.py |
Updated ThriftImporter and ThriftLoader for better Python version compatibility, included importlib modules for module loading. |
thriftpy2/parser/parser.py |
Removed conditional check for Windows and Python version. |
🐇✨
Changes abound, the code does leap,
Across the Python versions, so deep.
No more skips, nor imports in vain,
Our library grows, without the chain.
Together we hop, to the future we peer,
With code more clean, the path is clear.
🌟🐾
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
I think we should keep this PR small to make it easy to review. So the removal of _compat.py
will be in separate PRs.
Summary by CodeRabbit