search

Thriftpy / thriftpy2

Pure python approach of Apache Thrift.
MIT License
562 stars 89 forks source link

Support build cython codes with `-Werror=strict-aliasing` #247

Closed aisk closed 4 months ago

aisk commented 4 months ago

Cython does not support using * operator to dereferencing a pointer, so the old code is using [0] for this job. However, this usage can't be built with -Werror=strict-aliasing, see #246 for details.

In this PR, using memcpy to force cast a double to an int64_t to do the job. This can be built on my machine with -Werror=strict-aliasing.

Hi @eli-schwartz can you help me test it on your machine?

Close #246

Summary by CodeRabbit

coderabbitai[bot] commented 4 months ago

Walkthrough

The update in thriftpy2/protocol/cybin/cybin.pyx involves refining the handling of double values by utilizing memcpy for reading and writing operations. This approach is aimed at addressing strict-aliasing rule violations that previously led to compilation issues, thus enhancing the code's compliance with C standards without compromising on performance or functionality.

Changes

Files Change Summary
.../cybin/cybin.pyx Introduced memcpy for handling double values, replacing direct casting to mitigate strict-aliasing violations.

Assessment against linked issues

Objective Addressed Explanation
Identify and resolve strict-aliasing violations in generated C code (cybin.c) (#246) ✅
Address strict-aliasing rule violations in __pyx_f_5cybin_write_double and __pyx_f_5cybin_c_read_val (#246) ✅
Investigate alternative methods for double value manipulation to avoid strict-aliasing violations (#246) ✅ Using memcpy is an alternative method that avoids these violations.
Ensure changes maintain functionality and performance related to double value bit manipulation (#246) ✅
Test for compilation without strict-aliasing errors and correct function in thriftpy2 context (#246) ❓ The summary does not explicitly mention testing, but the change implies a technical solution that should address the issue.
Document changes made to address strict-aliasing violations (#246) ❌ The summary does not mention documentation of the changes.

Poem

To the rhythm of the bits, a rabbit hops and sits,
🐇💻 In the code, it found a glitch, with a twitch.
With memcpy in its kit, it made a fix so slick,
No more aliasing, so strict, a seamless stitch.
Now the code compiles, so quick, without a hitch,
Celebrate the patch, so neat, without a snitch.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with CodeRabbit: - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit-tests for this file.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit tests for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit tests.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger a review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - The JSON schema for the configuration file is available [here](https://coderabbit.ai/integrations/coderabbit-overrides.v2.json). - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json` ### CodeRabbit Discord Community Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback.
eli-schwartz commented 4 months ago

Hi @eli-schwartz can you help me test it on your machine?

The change itself compiles fine. I don't think much of the chatbot's ineffectual analysis though.