search

Thriftpy / thriftpy2

Pure python approach of Apache Thrift.
MIT License
562 stars 89 forks source link

Support use mp spawn mode for tests #263

Open cocolato opened 3 months ago

cocolato commented 3 months ago

Fix: https://github.com/Thriftpy/thriftpy2/issues/260

cocolato commented 3 months ago

Maybe 3.6 testing should be skipped. I'm not sure if this implementation is what we want.

aisk commented 3 months ago

I think this approach is fine for me. But there are some tests that have been skipped because they require fork to start multiprocessing. So with this change, if this approach can solve the problem, we should enable these skipped tests to ensure that this change works as we expected.

For skipping the test on Windows with Python 3.6, I think maybe multiprocess does not support some functionalities on Windows with Python 3.6. So I'm fine with skipping it, but since it passed on Linux, I think we can modify the build.yaml to have it only skip on Windows with Python 3.6.