search

Thriftpy / thriftpy2

Pure python approach of Apache Thrift.
MIT License
572 stars 91 forks source link

Default timeout in thriftpy2.rpc.make_client() is different from thriftpy.rpc.make_client() #96

Closed lexa closed 4 years ago

lexa commented 4 years ago

Hello,

I've noticed that the default timeout in thriftpy2.rpc.make_client() differs in the old thriftpy:

thriftpy2.rpc.make_client(service, host='localhost', port=9090, unix_socket=None, proto_factory=<cybin.TCyBinaryProtocolFactory object at 0x7fc655ef3400>, trans_factory=<thriftpy2.transport.buffered.cybuffered.TCyBufferedTransportFactory object at 0x7fc655ef3240>, timeout=3000, cafile=None, ssl_context=None, certfile=None, keyfile=None, url='')

thriftpy.rpc.make_client(service, host='localhost', port=9090, unix_socket=None, proto_factory=<cybin.TCyBinaryProtocolFactory object at 0x7fc656bf9ba8>, trans_factory=<thriftpy.transport.buffered.cybuffered.TCyBufferedTransportFactory object at 0x7fc65b171a90>, timeout=None, cafile=None, ssl_context=None, certfile=None, keyfile=None)

The timeout was introduced in #60 which broke compatibility with the old thriftpy.

ethe commented 4 years ago

Yes, I think it should be an incompatible upgrade, sorry it is my fault, you can manually set it to None again.