ThrunGroup / FastForest

7 stars 0 forks source link

Fix O(N) fallbacking #157

Open motiwari opened 2 years ago

motiwari commented 2 years ago

This has several steps:

motiwari commented 2 years ago

Yes, min_impurity_reduction is normalized by the dataset size. Since we use proportions, we're only using p in the calculation of impurity.

The same is true for entropy.

It looks like the same is true for MSE, but I'm not sure. Since it is "mean" I would expect so