Closed gannebamm closed 2 days ago
Current state of the footer when using the subsites module:
Not sure whether logos should be centered or to the left
@kilichenko-pixida please test making style changes via admin theme and if changes do not apply ask upstream for help.
There had been a small discussion around the topic here: https://github.com/geosolutions-it/geonode-subsites/issues/42
Documentation has been updated: https://github.com/Thuenen-GeoNode-Development/thuenen_atlas/blob/subsite_holisoils/geonode/templates/subsites/README.md
Discussion on theme/styling when deployed on https://geonode-demo.thuenen.de/#/
In the template some of the cards are not shown completly and the bottom is cut by the project partners:
base template:
subsite template:
footer issue fix to be tested: https://github.com/Thuenen-GeoNode-Development/thuenen_atlas/commit/22a0228100f26d2999ab72fabdbadc048df0c0d4
TODO: @ridoo check broken footer links
Can't reproduce the footer issue after the fix, here is what it looks like for me locally on the latest version of thuenen_4.x @ridoo @gannebamm
@gannebamm as expected the dead links were related to a wrong ordering of the urlpatterns. I pushed a fix just now. Feel free to test
Some things are fixed but there are still some CSS glitches:
Expected
You can see the dot and some space at the end of scrolling.
Behaviour
lots of empty space and vertical scrol even though it is not needed.
Some things are fixed but there are still some CSS glitches:
I'll look into it
@gannebamm It seems to me the reason this empty space appears is due to only having one resource selected and is not related to the subsites. I've tried to test it both locally and on stable (without subsites), and if there are very few resources to fill the space (e.g. just 1), that's how it's being displayed, browser sizing doesn't seem to affect it. Here is a screenshot from stable:
Let me know if this is something that still needs to be addressed or I am just missing something
Hi , If I may add one point here, the scroll bar should not be there when there are no more layers available. On the stable version, as you have also shown, there is still some space , but its without 'scroll bar' and has a very clean look. Also, I checked the screenshots in the documentation part also here https://docs.geonode.org/en/master/basic/theme/index.html , where it has no resources, still it has clean look and without scroll bar. The white space is justified though.
@vineetasharma105 Ah, I see your point, thanks, I'll look for a fix s.t. the scroll bar doesn't appear
@vineetasharma105 I looked into it and it seems that the observed difference is not due to the footer, but due to the different layout shown in this example (with pages, as seen in the url with &page=1) the scrollbar also disappears on the holisoils subsite. Also, on the screenshot I attached above of the single resource seen on stable the scroll bar was actually also present, just was cut out of the screenshot
I think we are done here, right @VeraZimt @vineetasharma105? Otherwise reopen with comment.
This issue is part of #24
Problem: The current GeoNode Version 4.x is a single page application. It will not show the project partners in the footer element like version 3.x.
Objective: As administrator I want to show project partners logos. An example of the functionality is shown at the current Thünen ATLAS (https://atlas.thuenen.de/) which is based on version 3.x of GeoNode:
In the screenshot below the homepage of the Thünen ATLAS is shown. In the footer area the partners are listed with their logos.
The screenshot below is showing the version 4.x homepage. The partners and logos are no longer displayed. A possible placement would be in the footer element of the start page.