hvwaldow
commented
3 months ago Open gannebamm opened 4 months ago
hvwaldow
commented
3 months ago 
ridoo
commented
3 months ago @hvwaldow and @ridoo will meet bilaterally to discuss update strategy
ridoo
commented
3 months ago Handle directly in combination with https://github.com/Thuenen-GeoNode-Development/thuenen_atlas/issues/32
ridoo
commented
3 months ago @gannebamm @hvwaldow
Here's a check-list/todo-list with comments:
GeoNode
https://github.com/Thuenen-GeoNode-Development/Sprints/issues/7:
Import metadata has been removed from since v4.3.x. The geonode-importer now handles XML file upload. Changes from https://github.com/Thuenen-GeoNode-Development/Sprints/issues/7 would have to be adjusted there accordingly.
In the importer the workflow is a bit different. The "Apply existing metadata to another dataset" approach would have to be ported. I will create a separate issue for this one.
sunburst. We would have to port the sunburst charts to the current version (there was a big refactoring in the meantime). Some features since we forked:
I suggest to create new issues for the MapStore2 issues (as I did for the GeoNode tasks).
Already migrated/checked:
gannebamm
commented
2 months ago We can savely bump GeoServer to:
GEOSERVER_BASE_IMAGE_VERSION="2.24.4-v1
GEOSERVER_DATA_BASE_IMAGE_VERSION="2.24.4-v1"Which does include the proper fix for CVE-2024-36401 .
gannebamm
commented
2 months ago RE:
MapStore2
- https://github.com/52North/thuenen-atlas-geonode-v4/issues/14: Floating Legend have to be re-evaluated as https://github.com/geosolutions-it/MapStore2/pull/9983 have happened in the .. see https://github.com/GeoNode/geonode-mapstore-client/issues/1266#issuecomment-2306732342
- https://github.com/52North/thuenen-atlas-geonode-v4/issues/11: Chart handling has improved a lot since we added sunburst. We would have to port the sunburst charts to the current version (there was a big refactoring in the meantime). Some features since we forked:
- Multivariate chart improvements (https://github.com/geosolutions-it/MapStore2/issues/8588)
- Advanced Options (https://github.com/geosolutions-it/MapStore2/issues/9071, https://github.com/geosolutions-it/MapStore2/issues/9072)
- Legends with percent for pie chart (https://github.com/geosolutions-it/MapStore2/issues/9617)
We need to re-evaluate those features. Floating legend for example is with the new mapping configurations almost obsolete, since we set the default for the TOC to be open and the legend to be visible (please check on stable.demo.geonode.org @vineetasharma105).
gannebamm
commented
2 months ago and this:
- [ ] Integrate "local" update on tisdar.dev.thuenen.de (https://github.com/Thuenen-GeoNode-Development/thuenen_atlas/issues/23) into tuenen_atlas 4.x.
Is already fixed and done if we move to any version above 4.2.3
ridoo
commented
2 months ago Sprint Review:
ridoo
commented
2 months ago @gannebamm | @kilichenko-pixida integration of subsites into v4.3.x has to be reviewed also: https://github.com/geosolutions-it/geonode-subsites/issues/40
ridoo
commented
2 months ago Kick-off with GeoSolutions by end of Sept (25th). Some resources may be spent for this Sprint.
ridoo
commented
2 months ago Integrate https://github.com/Thuenen-GeoNode-Development/thuenen_atlas/issues/24 as well
@gannebamm | @kilichenko-pixida integration of subsites into v4.3.x has to be reviewed also: https://github.com/geosolutions-it/geonode-subsites/issues/40
Subsites (https://github.com/Thuenen-GeoNode-Development/thuenen_atlas/issues/24) are now available from thuenen_4.x branch.
ridoo
commented
1 month ago @vineetasharma105 please take a look at the chart functionality in particular (sunburst is out and will be tackled in a different issue)
vineetasharma105
commented
1 week ago
I have checked the BAR and PIE charts and the screenshot depicts the different charts. Chart functionality worked good.
vineetasharma105
commented
1 week ago
As can be seen , the timeslider has no effect on the bar chart. Although the time slider is set to year 2010 (highlighted in red box bottom right) and the data displayed on the layer is also for filtered for that year, but the corresponding change on the bar chart is not synced and the bars stil holds the values of the whole dataset and not just for year 2010.
@gannebamm : do we need to work on this issue in this sprint ?
ridoo
commented
1 week ago @vineetasharma105 this may be related to https://github.com/Thuenen-GeoNode-Development/thuenen_atlas/issues/42
vineetasharma105
commented
1 week ago Yes, right. I wanted to write this to make sure I myself get reminded of this problem while working on charts.
Also, there was a note pop-up which said time slider and widget can not be used together. (highlighted in red box in following screenshot in the top right corner).
I should admit that I should have added this image also in the previous comment.
gannebamm
commented
1 week ago @vineetasharma105 @ridoo Widgets will not get filtered by time. This is the current behaviour and not a bug, see https://github.com/GeoNode/geonode-mapstore-client/issues/1473
Problem: As an administrator, I have to integrate the latest security updates and minor patches of the main project into the Thünen-ATLAS fork (https://github.com/Thuenen-GeoNode-Development/thuenen_atlas). This is time-consuming and requires some adjustments to the existing code.
Objective: As an administrator, I would like to be able to update the Thünen ATLAS via a pull of the customized fork. If special migration steps need to be taken into account, I would like to receive a description of these. The maintenance should include the next minor release (version 4.3.x), which is currently being developed: 4.3.1
Info: Some of the layout changes like mutually exclusive layers, TOC line breaks for titles and others are not needed anymore, since they are now part of core. The fork needs to get cleaned to get rid of those old deprecated code.