search

Thuenen-GeoNode-Development / thuenen_atlas

The Thünen Atlas GeoNode project
2 stars 1 forks source link

Fixed GDI-Compliance. #38

Closed ahmdthr closed 1 month ago

ahmdthr commented 2 months ago

The updates on pycsw alpha6 release requires to update the pycsw configuration structure. This PR updates the pycsw configurations required to create the ISO metadata.

gannebamm commented 2 months ago

This branch does look unclean @ridoo @ahmdthr ? Shouldn´t it only consist of the feature related commits (plus some merge commits maybe)?

AFAI can see only these commits do change the codebase: 4e0c3e3cfbb5aaed56266a48c191d16977ffa554 6e7deb43961606dd89011a9ad1b98da9e7b52cf9

right?

ahmdthr commented 2 months ago

This branch does look unclean @ridoo @ahmdthr ? Shouldn´t it only consist of the feature related commits (plus some merge commits maybe)?

AFAI can see only these commits do change the codebase: 4e0c3e3 6e7deb4

right?

You are right. Other commits in this PR were independently brought into the thunen_4.x. There are some changes required in this PR, I will rebase this branch on thunen_4.x and commit my changes related to clean it, unless @ridoo suggests otherwise.

ridoo commented 2 months ago

@gannebamm we also discussed some different approach using templatetags instead from overriding upstream stuff

gannebamm commented 1 month ago

@gannebamm we also discussed some different approach using templatetags instead from overriding upstream stuff

this seems like the better approach. please go ahead.

ridoo commented 2 weeks ago

@ahmdthr @gannebamm it would be nice to create an upstream PR containing the role mapping to resolve https://github.com/GeoNode/geonode/issues/12534