ThumbWorks / sf-ios

An app for iOS social events in SF
MIT License
19 stars 13 forks source link

The app uses the user's local time zone instead of the group's time zone #151

Open jamescmartinez opened 4 years ago

jamescmartinez commented 4 years ago

While setting up the Chicacoland iOS Coffee group, @joshdholtz discovered a time zone discrepancy between the app and the site.

The site uses the group's time zone instead of the user's time zone. The app uses the user's time zone and does not use the group's defined time zone.

Here's what the data looks like:

We should discuss a solution that is consistent across both web and mobile.

I'm personally leaning toward showing events in the group's time zone instead of the user's time zone. The counter-argument would be if you want to join remotely for whatever reason, you'd need your local time zone instead of the group's time zone. With that said, both Meetup and Eventbrite use the approach the site uses now, displaying events relative to the event location rather than the user's current location.

What do you all think?

mcritz commented 4 years ago

Server should be the source of truth.

jamescmartinez commented 4 years ago

It is now, but both platforms just handle dates differently. This might be more of a UX question than it is a data question. I think it comes down to:

Do we want users to see dates in their local time zone or in the time zone of the group?

Once we figure that out we can figure out the best way to get the right data to the app so we're consistent across the board no matter which UX approach we choose.

joshdholtz commented 4 years ago

I think seeing in timezone of the event makes the most since. If I looked at the app before I came to SF I would expect to be able to see it in Pacific timezone (otherwise it would probably mess up my planning 😊 )

rodericj commented 4 years ago

I agree with what josh said.

On Mar 6, 2020, at 11:50 AM, Josh Holtz notifications@github.com wrote:

 I think seeing in timezone of the event makes the most since. If I looked at the app before I came to SF I would except to be able to see it in Pacific timezone (otherwise it would probably mess up my planning 😊 )

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or unsubscribe.

jamescmartinez commented 4 years ago

That seems to be others' reactions as well from when Meetup switched from the user timezone to the event timezone. http://www.discussmeetup.com/forum/techy-issues-and-workarounds/time-zones-in-new-meetup/

In this case, the iOS app can convert to the group's time zone. When the API returns a group, it returns a time_zone: https://github.com/jamescmartinez/coffee/blob/master/docs/openapi.yaml#L74

mcritz commented 4 years ago

Agreed. This is a good enhancement to get done properly before dubdub