search

ThumbWorks / sf-ios

An app for iOS social events in SF
MIT License
19 stars 13 forks source link

Feature/improved image caching #69

Closed mcritz closed 5 years ago

mcritz commented 5 years ago

This branch adds network caching. All network requests should be cached to some degree. Even between launches.

WITH THIS FEATURE Given a coffee fan And app When networking is enabled Then networked requests are cached And UI is populated with events And UI for events has images

When networking is not enabled Then network requests are fulfilled by the previously cached data And UI shows “Error fetching events” dialog And UI is populated with events And UI for events has images

UNLIKE TODAY Given a coffee fan And app When networking is not enabled And UI shows “Error fetching events” dialog Then network requests are not fulfilled (in any circumstance) And UI is not populated with events And UI for events do not have images

rodericj commented 5 years ago

I really like your PR descriptions. You're a real pro.

rodericj commented 5 years ago

Good stuff. Safe to assume you ended up testing this with your wifi off?