search

ThummeTo / FMIFlux.jl

FMIFlux.jl is a free-to-use software library for the Julia programming language, which offers the ability to place FMUs (fmi-standard.org) everywhere inside of your ML topologies and still keep the resulting model trainable with a standard (or custom) FluxML training process.
MIT License
57 stars 15 forks source link

Fix#110 #111

Closed juguma closed 9 months ago

juguma commented 1 year ago

fixes #110 plus adds two missing packages to the supported_sensitivities.jl-test

juguma commented 11 months ago

Jep, if you run this file inside all runtests.jl, you are right, it is loaded. But I don't see a point why it should not be loaded in the script itself such that you can run the script independently, as far as I know it doesn't harm performance. I added it in the supported_sensitivities.jl because I am running this very script not via runtests.jl, without claiming that one should always add all packages in the different files (that is actually something I wanted to discuss with you, cf. the agenda in my last mail). I felt confirmed that it actually doesn't matter by looking into the other test scripts where some packages were added redundantly.

ThummeTo commented 11 months ago

We can discuss that, but it is a bit uncommon to have self-contained testing sub-scripts, because there is often redundant code that could be used among different files. In any case (self-contained or not) this should be consistent for all test scripts.

ThummeTo commented 9 months ago

This is solved in v0.11.1.