Closed manuelbb-upb closed 1 year ago
Thank you very much, we will check the PRs and merge if everything is ok. Much appreciated 👍
@JoKircher
Sure, I will give it a look
Thanks for the review and sorry for not running the unit tests. Will submit a commit soon adding some documentation.
Based on the changes in https://github.com/ThummeTo/FMICore.jl/pull/33, this pull request modifies parsing of a model definition such that the
modelDescription
of anFMU2
actually holds non-trivialtypeDefinitons
andunitDefinitions
if present.There is also post-processing for the model variables to set the attributes according to a
declaredType
if applicable, i.e., if an attribute is not defined for the model variable but for the relevant SimpleType.Lastly, there is a convenience function
fmi2GetUnit(model_description, model_variable)
to retrieve the unit corresponding tomodel_variable.Real.unit
frommodel_description.unitDefinitions
.Marked as “draft” because: