Found some bugs

[John-H-Smith]

If Lava or water was set in an arena, it will not be rollbacked after the game. Then, the thunder is heard by all players in the world, and the message messages.game.playerwin in messages.yml can be red from all players in all worlds, even if they are in an active SG round or not. So, there is no messages.yml path to edit the "Joining Arena X". And the "You have a X second grace period" message too. The "Grace period has ended" message (messages.game.graceperiodend in messages.yml) is not loaded into the game. The default will be used. Thanks for changing, I like your plugin!

[ThunderGemios10]

Are there any errors on the console log?

What version of Spigot are you using?

[John-H-Smith]

There are no errors in the console log. All is starting fine. Spigot version is 1.11.2

[ThunderGemios10]

Strange..

Any other details that i should be aware of?

[ThunderGemios10]

Also, this might be the cause of other plugins.

[John-H-Smith]

@ThunderGemios10 Which of those bugs?

[John-H-Smith]

So, there is no messages.yml path to edit the "Joining Arena X".

the code to this msgmgr.sendMessage(MessageManager.PrefixType.INFO, (new StringBuilder()).append("Joining Arena ").append(gameID).toString(), p); for me in line 224. Can you edit this for adding in messages.yml?

[ThunderGemios10]

@masterstreamer Now, i have no idea what causes the map problem. But regarding the message.yml problem. I'll have to check out the codebase.

[John-H-Smith]

@ThunderGemios10 Thank you, do you know which plugin could cause the map problem? I use Multiverse for this. If you've no time for debugging the code for this Errors, I could do it for you if you want.

[ThunderGemios10]

@masterstreamer Sure, if you want to. As for the map problem, can you tell me your full plugin list?

[John-H-Smith]

Of course! Here we go AdvancedBan Antibot-Ultra AreaShop AsyncWorldEdit AsyncWorldEditInjector AutoMessage ChestShop CommandWatcher EntityLWC Essentials EssentialsChat EssentialsProtect EssentialsSpawn iConomyRecreation Jail Lift LogBlock Multiverse-Core Multiverse-Portals NoCheatPlus orebfuscator Paintball PermissionsEx PetitionPlugin (own development) PriceCalculator (own development) ServerSigns ServerStats (own development) SilentClear (own development) SilentTeleport (own development) SimplePVP (own development) SkinsRestorer Survival-Games Vault WeatherMan worldedit worldguard

[John-H-Smith]

So do you have any news for me?

[ThunderGemios10]

@masterstreamer Haven't done a thorough search, since i have been busy in school. I did do a quick browse and have not be able to find the problem. Maybe i have overlooked something?

[John-H-Smith]

@ThunderGemios10 Hrm. I think you set a variable or something to true if a player uses /sg join. So you could add a new "broadcastLobbyMessage" in MessageManager, which only sends to the players where the variable set to true. If the player disconnects or leaves the lobby the variable should be set to false. I think that would be the best way. Or do you have any other ideas? And because the thunder (lightning), I think the ArrayList activePlayers uses all players on the server, doesn't it? So you could change it to the variable defined above. I'm not very known with bukkit, but this would be the way I would try it.

[John-H-Smith]

@ThunderGemios10 do you have checked this?

[ThunderGemios10]

@masterstreamer I can't think of anything else that is conflicting with the plugin unless it is caused by your own developed plugins.

[ThunderGemios10]

@masterstreamer I'll run a test soon.

[ThunderGemios10]

@masterstreamer You should try to use the plugin in a server without other plugins and see if that fixes it.

[John-H-Smith]

Without is a bad idea, so I cannot reproduce the other worlds, but only with multiverse I could!

[ThunderGemios10]

@masterstreamer Ah sorry, i forgot to take Multiverse into account. You should try it on a server with the plugin and Multiverse.

[John-H-Smith]

I will try it.

[John-H-Smith]

@ThunderGemios10 Ok, I tried, but I encountered a further error: if I'm not in an arena, or something which should cause an error message, it does not say the error message string, but the path. Like so: [SG] [Error] error.gamenoexist Only plugins: Worldedit, Multiverse, Survivalgames

[ThunderGemios10]

@masterstreamer Are there any errors in the console log?

[John-H-Smith]

@ThunderGemios10 I think not, maybe this is for debugging:

[15:39:50] [Server thread/INFO]: XXX issued server command: /sg setspawn next
[15:39:50] [Server thread/INFO]: settings spawn
[15:39:50] [Server thread/INFO]: -1 1

[John-H-Smith]

@ThunderGemios10 I just tested this on a empty server! You can hear the thunder only in the same world, but all over the world. The message messages.game.playerwin could be red by all players in all worlds. There are no errors in the console log.

[John-H-Smith]

@ThunderGemios10 hey there, do you red the above?

[ThunderGemios10]

@masterstreamer Hmm. I think the latest Spigot API broke the plugin which i can't determine for sure.

[John-H-Smith]

@ThunderGemios10 Okay, so will you try to fix that? Unhappily I can't use your plugin before that was fixed.

[John-H-Smith]

@ThunderGemios10 are there any news about this?