sshipway
commented
8 years ago Here's how my fix works.
- The FIRST time a chest is opened in a game, its contents is copied to a cache.
-- If the chest contains a wool block in slot 0, then 1 is added to the DV to give the base level, else base level is 1 -- The wool block (if any) is removed -- If the clear-chest option is TRUE, all the other items are removed as well -- The base level is increased by up to 4 on a 1-in-ratio basis (where ratio is set for the level in the chest.yml) -- Randomly 0-7 items are added to the chest, randomly selected from the level in chest.yml with each line of equal weight. Selections are independent so you can have multiple copies of the same thing -- These items can be specified as text or as number, with quantity, DV, enchantments and names - The next time the chest is opened, nothing is changed
- If the restock-chest is set, then the chests are all reset after 1 day. -- This will remove any current content and replace it, not add to it
- If restock-chest-repeat is set, this happens EVERY day (14400 ticks)
- When the arena is reset, -- All the previously-opened chests revert to their previous content, including any wool block in slot 0 -- All entities are removed apart from the ones listed in entities.keep in the config.yml (this includes dropped items and xp orbs) Default is to exclude pictures, frames, minecarts and armour stands. -- All modified blocks revert to their previous state
- Arena resets on shutdown, game end, and on new
/sg resetarenacommand
This does not fix frames, droppers, or dispensers. Kept entities are not moved back to their original locations if they moved.
Thus, in your HG world, you can place a block of coloured wool in every chest slot0 to indicate what tier of loot it should contain. You can also place special items into specific chests and set clear-chest=false so that they are kept on randomisation.
Obviously this needs a bit of testing. There may be a race condition in the reset code, and the original author did not put in much in the way of error trapping and debug messages, so I'm going to let the kids loose on it and see what happens. They want "opey loot" and since the default chest level is 1 they wont get this until I prime all the chests with a wool block.
ThunderGemios10
XinityDevs
When the world is reset, only block changes are reset, not Inventories or other metadata. This means
Checking the code seems to show that a chest's content is randomly updated on first open by
ChestReplaceEventto match the selected level in chest.yml; this level is picked by the colour of the wool in slot 0 or else 1. However the items previously there are all deleted first. The nightly 'chest restock' is actually just clearing the array of chests already visited, so that they are reloaded on next open. This would seem to be a big thing to fix as theGameManager.openedChesthashset would need to become a hashmap holding the original inventory, and the clear of this map done at arena reset or at chest restock would need to also reload the original content back into the chests; thus a new function for resetChests rather than just clearing the array.This still does not solve the problem of how droppers/dispensers/armourstands/frames/etc should be correctly reset. Droppers and dispensers in particular are difficult as they are usually triggered by redstone and so catching the player interact event will not work.