ThunderGemios10 / Survival-Games

Survival Games plugin for Spigot - UPDATED for 1.13+
https://www.spigotmc.org/resources/survival-games.17740/
GNU General Public License v3.0
25 stars 22 forks source link

problem with config/bandage not disappearing #89

Closed Gorbiel closed 4 years ago

Gorbiel commented 4 years ago

Describe the bug

  1. Players can't place or destroy blocks. I tried editing the config. I tried with and without "minecraft:" - uppercase and lowercase (for example minecraft:oak_leaves, oak_leaves, OAK_LEAVES)
  2. After using paper named "bandage" the item is still in player's inventory, so he can spam and use it continuously without consuming the paper

I attached the config files. configs.zip

Specfiy which versions your using

Remyk1 commented 4 years ago

Are there any errors in console?

  1. The names should match https://hub.spigotmc.org/javadocs/spigot/org/bukkit/Material.html preferably uppercase (this issue might be related to #83 #84 )
  2. Does it work with plain paper (no name, enchantments)?
Gorbiel commented 4 years ago

So I switched to .jar from issue #83 and it seems to show up in console, but there's another issue with that: [SurvivalGames] [Debug] PlaceEvent: read : [COBBLESTONE, TORCH, CAKE, OAK_PLANKS, OAK_LEAVES, MELON] [20:02:35 INFO]: [SurvivalGames] [Debug] BreakEvent: read : [COBBLESTONE, TORCH, CAKE, OAK_PLANKS, OAK_LEAVES, MELON]

It ignores the block-place whitelist and uses block-break whitelist for both categories. This is my config: block: place: whitelist:

Gorbiel commented 4 years ago

With jar file from spigot there was "null" everywhere (PlaceEvent: read : [null, null, null, null, null, null])

Remyk1 commented 4 years ago

90 should fix this issue

Gorbiel commented 4 years ago

Thank you very much, it took me a while to learn how to build this thing but now it seems to work. I can't test it now but when I do I'll close this thread

Remyk1 commented 4 years ago

Which repo did you clone because i didn't merge #90 into this repo yet. If you want to test it you can clone https://github.com/Remyk1/Survival-Games.git If you have maven installed just open a shell(cmd or bash) and run mvn clean install in the directory where the pom.xml file is.

Gorbiel commented 4 years ago

I cloned it from your repo and built it using maven in eclipse. The plugin detects config correctly but still nobody can place/break anything

Gorbiel commented 4 years ago

Here is my latest log and all the config files. I made sure that worldguard doesn't interfere with Survival Games and tested with and without op on the server. latest.zip

Gorbiel commented 4 years ago

But the good news is that bandages work flawlessly

Remyk1 commented 4 years ago

Ok i added an excessive amount of debugging to place event Survival-Games.zip

Gorbiel commented 4 years ago

latest.log

Remyk1 commented 4 years ago

Can you try this jar Survival-Games.zip

Gorbiel commented 4 years ago

latest.log Unfortunately there's no change

Remyk1 commented 4 years ago

I think this should fix it Survival-Games.zip

Gorbiel commented 4 years ago

Finally! Everything's working. Thank you very much!

I have a suggestion - after the end of the game xp also gets reset. And maybe if you win you earn some server money (the vault one). I would try to add this with pull request, but I don't know java