ThunderLoom / ThunderLoom

A physically based shader for woven cloth
MIT License
99 stars 19 forks source link

Mult helper sliders for colors. #2

Closed petermcevoy closed 7 years ago

petermcevoy commented 7 years ago

Suggested by Derek Flood.

petermcevoy commented 7 years ago

We think these sliders do not really belong in the Shader. These manipulations might be better to do outside the shader, as a node in the node-graph. Just to keep the shader a bit focused on the task. Currently the diffuse slider and texture input it works just like the diffuse parameter in VRayMtl.

sharktacos commented 7 years ago

@petermcevoy Maya 2017 color management makes having the texture gamma unnecessary. So I agree the texture gamma should not be included in the shader.

It would be nice to have a diffuse amount slider though, just like in a VRayMtl. You say "Currently the diffuse slider and texture input it works just like the diffuse parameter in VRayMtl" so does that mean the diffuse amount slider has been implemented?

-Derek

petermcevoy commented 7 years ago

Forgive me, again not very familiar with Maya, so I am probably missing something... But looking at the VRayMtl node in Maya, I can not see a multiplier/amount slider? Except the slider at Diffuse Color, which gets disabled if we link a texture (this functionality we do have).

screenshot 2017-09-04 17 14 16

screenshot 2017-09-05 01 31 34

sharktacos commented 7 years ago

@petermcevoy,

The Properties Editor you posted above is not showing all of the attributes in the VrayMtl, which is admittedly confusing. To see all the attributes you need to view the shader in Maya's Attribute Editor. This is a screen shot from the diffuse ("basic parameters") section of a VrayMtl:

image

There you can see the diffuse amount slider

From the Chaos manpage for the VrayMtl: https://docs.chaosgroup.com/display/VRAY3MAYA/V-Ray+Material+%7C+VRayMtl

Diffuse Color – The diffuse color of the material. Note: the actual diffuse color of the surface also depends on the reflection and refraction colors.

Amount – A multiplier for the diffuse color.

Opacity Map – Assigns opacity to the material where white is completely opaque and black is completely transparent. You can also assign a map by clicking the check board button. This way you can create a material that has a non-uniform opacity.

...come to think of it, having an opacity color input would be quite useful in the Thunderloom shader for semi-transparent "sheer" materials.

Similarly the reflection color of a VrayMtl in Maya also has a reflection amount slider under it.

image

-Derek

petermcevoy commented 7 years ago

Ah ok, I see, thank you. I missed that. A diffuse amount slider would then be good.

Will make a new issue for opacity.

sharktacos commented 7 years ago

@vidarn @petermcevoy Could this be added to the 1.0 milestone? With a texture map in either the diffuse color or specular color, it's pretty essential for an artist to have an amount slider to modulate this color.

petermcevoy commented 7 years ago

Yes, I think that makes sense. Will do.