search

Thunderbottom / UltimateBrowserProject

android browser based on webview
http://bit.ly/XDAUBP
162 stars 59 forks source link

Switching tabs after showing omnibox #47

Closed james9909 closed 9 years ago

james9909 commented 9 years ago

Upon hiding the omnibox, then showing it again, switching tabs causes the app to crash. The problem appears to be caused here.

Thunderbottom commented 9 years ago

Was this happening before you changed the code?

Thunderbottom commented 9 years ago

Here's the log that you might have gotten -

java.lang.NullPointerException: Attempt to invoke virtual method 'int android.widget.RelativeLayout.getVisibility()' on a null object reference
       at io.github.UltimateBrowserProjectBeta.View.SwitcherPanel.onInterceptTouchEvent()
       at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java)
       at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java)
       at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java)
       at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java)
       at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java)
       at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java)
       at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java)
       at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java)
       at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java)
       at com.android.internal.policy.impl.PhoneWindow$DecorView.superDispatchTouchEvent(PhoneWindow.java:2679)
       at com.android.internal.policy.impl.PhoneWindow.superDispatchTouchEvent(PhoneWindow.java:1797)
       at android.app.Activity.dispatchTouchEvent(Activity.java)
       at com.android.internal.policy.impl.PhoneWindow$DecorView.dispatchTouchEvent(PhoneWindow.java:2640)
       at de.robv.android.xposed.XposedBridge.invokeOriginalMethodNative(XposedBridge.java)
       at de.robv.android.xposed.XposedBridge.handleHookedMethod(XposedBridge.java:684)
       at com.android.internal.policy.impl.PhoneWindow$DecorView.dispatchTouchEvent(<Xposed>)
       at com.android.internal.policy.impl.MultiPhoneWindow$MultiPhoneDecorView.dispatchTouchEvent(MultiPhoneWindow.java:550)
       at android.view.View.dispatchPointerEvent(View.java)
       at android.view.ViewRootImpl$ViewPostImeInputStage.processPointerEvent(ViewRootImpl.java)
       at android.view.ViewRootImpl$ViewPostImeInputStage.onProcess(ViewRootImpl.java)
       at android.view.ViewRootImpl$InputStage.deliver(ViewRootImpl.java)
       at android.view.ViewRootImpl$InputStage.onDeliverToNext(ViewRootImpl.java)
       at android.view.ViewRootImpl$InputStage.forward(ViewRootImpl.java)
       at android.view.ViewRootImpl$AsyncInputStage.forward(ViewRootImpl.java)
       at android.view.ViewRootImpl$InputStage.apply(ViewRootImpl.java)
       at android.view.ViewRootImpl$AsyncInputStage.apply(ViewRootImpl.java)
       at android.view.ViewRootImpl$InputStage.deliver(ViewRootImpl.java)
       at android.view.ViewRootImpl$InputStage.onDeliverToNext(ViewRootImpl.java)
       at android.view.ViewRootImpl$InputStage.forward(ViewRootImpl.java)
       at android.view.ViewRootImpl$InputStage.apply(ViewRootImpl.java)
       at android.view.ViewRootImpl$InputStage.deliver(ViewRootImpl.java)
       at android.view.ViewRootImpl.deliverInputEvent(ViewRootImpl.java)
       at android.view.ViewRootImpl.doProcessInputEvents(ViewRootImpl.java)
       at android.view.ViewRootImpl.enqueueInputEvent(ViewRootImpl.java)
       at android.view.ViewRootImpl$WindowInputEventReceiver.onInputEvent(ViewRootImpl.java)
       at android.view.InputEventReceiver.dispatchInputEvent(InputEventReceiver.java)
       at android.view.InputEventReceiver.nativeConsumeBatchedInputEvents(InputEventReceiver.java)
       at android.view.InputEventReceiver.consumeBatchedInputEvents(InputEventReceiver.java)
       at android.view.ViewRootImpl.doConsumeBatchedInput(ViewRootImpl.java)
       at android.view.ViewRootImpl$ConsumeBatchedInputRunnable.run(ViewRootImpl.java)
       at android.view.Choreographer$CallbackRecord.run(Choreographer.java)
       at android.view.Choreographer.doCallbacks(Choreographer.java)
       at android.view.Choreographer.doFrame(Choreographer.java)
       at android.view.Choreographer$FrameDisplayEventReceiver.run(Choreographer.java)
       at android.os.Handler.handleCallback(Handler.java)
       at android.os.Handler.dispatchMessage(Handler.java)
       at android.os.Looper.loop(Looper.java)
       at android.app.ActivityThread.main(ActivityThread.java)
       at java.lang.reflect.Method.invoke(Method.java)
       at java.lang.reflect.Method.invoke(Method.java:375)
       at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java)
       at com.android.internal.os.ZygoteInit.main(ZygoteInit.java)
       at de.robv.android.xposed.XposedBridge.main(XposedBridge.java:117)
james9909 commented 9 years ago

Yes it was happening before I made the previous change.

james9909 commented 9 years ago

Bug seems to be fixed in this commit.

Thunderbottom commented 9 years ago

Sorry for replying late, was busy with Uni stuff. Must've been something with the Bottom bar scrolling, I need to add comments to every line I suppose.... and possibly better up the code format.

james9909 commented 9 years ago

Its fine, since I was inactive for a while, which I'm sorry about.

Thunderbottom commented 9 years ago

Yeah that's totally fine :)