search

Thunderbottom / UltimateBrowserProject

android browser based on webview
http://bit.ly/XDAUBP
162 stars 59 forks source link

New theme Incomplete #48

Closed Thunderbottom closed 8 years ago

Thunderbottom commented 9 years ago

@james9909 When are you completing the new theme? I suppose it's still pending here

james9909 commented 9 years ago

Yes, currently some items, like the dialogs, still need to have a dark version, but I'm not going to finish it soon because I'm on vacation.

Thunderbottom commented 9 years ago

Alright, I'll wait for you to finish that and then we'll add it to the new version

Thunderbottom commented 9 years ago

I've fixed some bugs and now you can print through the app itself. So I'll wait until you are do so we can release this new one

Thunderbottom commented 9 years ago

@james9909 can you finish the theme please, I'll land a new update soon before I'm done with this for a while?

james9909 commented 9 years ago

Okay, I'll finish it this weekend.

Thunderbottom commented 9 years ago

Alright thanks :)

james9909 commented 9 years ago

Can you check out the theme so far? I have pretty much everything covered, but I'm not sure what else you would like to be darkened. Additionally, instead of using an overflow menu in ClearActivity, couldn't we use the original 'done all' icon?

Thunderbottom commented 9 years ago

Yeah sure, will check it out real quick

Thunderbottom commented 9 years ago

Also, if I have mistaken some icon for something else, you can change it! :D

Thunderbottom commented 9 years ago

The themes don't work, its still light

james9909 commented 9 years ago

Did you launch the project from the feature-themes branch? It works for me.

Thunderbottom commented 9 years ago

yes I did, can you post some screens?

james9909 commented 9 years ago

Actually it might be because I only set the themes for lollipop or higher. I'll work on the themes for lower versions.

james9909 commented 9 years ago

I tested the dark theme on an emulator, so some things may not be perfect. Also, if you feel that any of the colors are off, feel free to change them to whatever.

Thunderbottom commented 9 years ago

Yeah i ran them on Bluestacks for test, the only page that was dark was the Readability menu

Thunderbottom commented 9 years ago

The colors are just fine, no need to change them

james9909 commented 9 years ago

Were the settings dark? I tried on a 4.4.4 emulator and it looked fine.

Thunderbottom commented 9 years ago

No, can you post some screenshots?

Thunderbottom commented 9 years ago

Alright you posted a newer version, let me check that out