[Discussion][Issue] Fix Bottom Omnibox

[Thunderbottom]

So Keyboard is shown above the bottom omnibox while typing, so it gets hidden behind the keyboard.

While scrolling, bottom omnibox hides (While scrolling top, should be reversed) and shows "about:blank: for a brief period like some Milliseconds when it starts hiding.

Overall, the omnibox has choppy animations, need to fix that too.

[xdevs23]

Yes, I saw that. Need to move it up when keyboard is shown. Also I think we should remove that "about:blank" thing and we should init the webview when the application starts, because when no tabs are open the webview doesn't exist, only after typing in an url and the previous sessions hasnt been restored. There are no animations on the omnibox. We have to create one to animate fade in/out like in chrome.

But it's not bad, is it?

[Thunderbottom]

It's not bad.

[xdevs23]

Don't worry everything has a solution.

[Thunderbottom]

Have you tried fixing this issue? We need to release a version soon, cause I'll be having a lot lesser time in December due to work and stuff.

[xdevs23]

Oh sorry, I didn't fix it, yet, I am currently very busy and also not working in the environment, which I use for android development, but in the next days I would have time to do it.

[Thunderbottom]

Alright, take your time.

[xdevs23]

See https://github.com/Thunderbottom/UltimateBrowserProject/commit/c447c5d8d3b89f9b299a1bd5195da006877c3e2b

Just need to fix keyboard

[Thunderbottom]

@xdevs23 some bugs that I found in the latest build-

• If you install the app for the first time, this screen is shown - Cannot Load URL
• Then when you click OK, this screen is shown-

[xdevs23]

Allright, will take a look.

[xdevs23]

Could you tell me the URL which is being loaded?

[Thunderbottom]

Asset file

[xdevs23]

Yea but is the URL correct?

[xdevs23]

Ok, the URL is correct, the issue seems to be that the webview doesn't get initialized correctly at first start-up. If you open a new tab, you can switch back to the first thread and it works.

Try creating a new tab or swipe the omnibox to left/right and it should initialize the webview:

[Thunderbottom]

Is it because of this

[xdevs23]

Ok I will see how to fix it

But we should leave that line untouched.

[xdevs23]

I already played around, but I'm not able to fix it properly. I don't really know how to handle that complex and mixed up layout.

The problem is that the first launch is not implemented correctly.

We should remove nearly everything that has to do with the first startup and just let it load the introduction URL on first startup.

I will take a look on that later, I think tomorrow.

[xdevs23]

I think it is more because of this and that and also that

[xdevs23]

@Thunderbottom Fixed the first launch! :grinning:

[Thunderbottom]

Nice, man. I just tested and saw that the omnibox tinting sometimes turns the omnibox transparent, and we need to fix bottom layout for when keyboard is used.

[xdevs23]

Yes, I saw that, too.

For keyboard I have a good idea, we can use onMeasure() to move the omnibox up when needed. There's no event for software keyboard so we have to use that

[xdevs23]

But there's another bug... When restoring tabs from last session, the wrong site is loaded. It doesn't load the last page that was open before closing UBP, it loads the page before the last or a random one.

After that all is fixed, we can release a new version, can't we?

[Thunderbottom]

Well, restoring website was fine. I'll take a look at it

[xdevs23]

Yes, I am having the problem that it loads the wrong page. If I was on 5 pages, it loads the 4th but sometimes a random one... I think we need to improve the way the pages are saved.

[xdevs23]

Now it's fixed :D

[Thunderbottom]

Bug? This happens every time. It happened since I installed it.

[xdevs23]

Doesn't happen to me, I tested on Marshmallow, KitKat and Jelly Bean. On physical and emulated devices.

[Thunderbottom]

Send an apk quick so I'll test on the go on some devices

[xdevs23]

Just rename it to UBPCustom.apk and there you go! UBPCustom.zip

Eventually deleting app data would help...